fix(controller): disallow custom optiomization #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will often break the inner workings of karma-webpack due to a number of issues coming in about this in particular it has been decided that it is best to ignore these kinds of customizations and log a warning that they are discarded Fixes #491
|
As #587 mentioned, this is a breaking change. Although #588 restore the previous behavior but still output a warning. We are running unit tests with karma with minify codes (using terser), which is required to ensuring that any unexpected result after minify process should not happened. Prior to this changes, we just keep Is there any other way to specify such as a terser options after "upgrade" to |
|
OK we will take this workarounds // karma.conf.js
const webpackConfig = ...
const {minimizer} = webpackConfig.optimization;
delete webpackConfig.optimization; // workarounds https://github.com/codymikol/karma-webpack/pull/578#issuecomment-2185779635
webpackConfig.plugins.push({apply : compiler => { compiler.options.optimization.minimizer = minimizer }});We hope we can have this done in a more elegant way |
|
I have a fix pending release, but my ssd gave out so it set me back quite a bit 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will often break the inner workings of karma-webpack due to a number of issues coming in about this in particular it has been decided that it is best to ignore these kinds of customization and log a warning that they are discarded
Fixes #491