Remove an optional dependency on symfony/intl #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine, I guess you wanted to support those people without the intl extension installed. It doesn't need to be a hard dependency. Btw, specs won't pass with symfony/intl as it only support English locale. |
|
well maybe just remove it |
jakzal
changed the title
|
I think that's the best thing to do. If someone wants to substitute the intl extension with symfony/intl, they can always install it themselves. PR updated. |
norberttech
pushed a commit
that referenced
this pull request
Jan 20, 2016
Remove an optional dependency on symfony/intl
|
thanks ;* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure where's this used in the library, but the current requirement prevents composer from installing it with Symfony 3.