chore: fix the theme of dropdown menu on articles page (dark mode)

[nawinsharma]

Fixes #(issue)
this pr fixes #1063

Pull Request details

• previously, the dropdown menu of article page was in light mode even the page was in dark mode.
• this pr implements the dark mode for dropdown sort by button

Associated Screenshots

fixes:

Screencast.from.2024-10-06.01-10-33.webm

[vercel]

@NawinKumarSharma is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Warning

Rate limit exceeded

@NawinKumarSharma has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 6 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between 17cf5c7 and eed987b.

Walkthrough

The changes in this pull request focus on the ArticlesPage component within the app/(app)/articles/_client.tsx file. The primary modification is the addition of a dark mode background style to the filter dropdown's <select> element. The class name has been updated to include a dark mode background, enhancing its appearance in dark themes. Additionally, the Create component's text color has been changed from white to black for better visibility, and the Tabs component's <select> element has been updated to support both light and dark mode backgrounds.

Changes

File Path	Change Summary
app/(app)/articles/_client.tsx	Updated <select> element's class name to include dark mode background style.
app/(app)/create/[[...paramsArr]]/_client.tsx	Changed main content text color from white to black for improved visibility.
components/Tabs/index.tsx	Updated <select> element's class name to include light and dark mode background styles.

Assessment against linked issues

Objective	Addressed	Explanation
Fix styling on "sort by" select on articles page (#1063)	✅

Possibly related PRs

• Update/headlessui #991: The changes in this PR involve updates to the Create component, which is also related to the UI components in the main PR. Both PRs modify the appearance of UI elements, specifically focusing on styling and class names for components that may share similar functionality.
• Refactor/onboarding form #992: This PR refactors the onboarding form to utilize Tailwind UI components, which aligns with the styling changes made in the main PR for the ArticlesPage component. Both PRs emphasize improving the UI through consistent styling practices.

Poem

In the dark mode glow, the dropdown shines,
A new style added, oh how it aligns!
With colors so bright, and choices so clear,
The articles page brings us cheer! 🐰✨
Hopping along, we celebrate this sight,
A joyful update, everything feels right!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Hello @NawinKumarSharma, thanks for opening your first Pull Request. The maintainers will review this Pull Request and provide feedback as soon as possible. Keep up the great work!

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

app/(app)/articles/_client.tsx (1)

82-87: LGTM! Dark mode fix implemented correctly.

The addition of dark:bg-neutral-800 to the className prop successfully addresses the issue of the dropdown menu appearing in light mode when the page is in dark mode. This change is consistent with the dark mode theme used elsewhere in the application.

For improved consistency, consider adding dark:text-neutral-50 to ensure the text color also adapts to the dark mode theme.

Here's a suggested minor improvement:

- className="mt-2 dark:bg-neutral-800 block w-full rounded border-neutral-300 py-1 pl-3 pr-10 text-sm leading-6 focus:ring-2 focus:ring-pink-600 dark:border-neutral-600"
+ className="mt-2 dark:bg-neutral-800 dark:text-neutral-50 block w-full rounded border-neutral-300 py-1 pl-3 pr-10 text-sm leading-6 focus:ring-2 focus:ring-pink-600 dark:border-neutral-600"

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 84efd0a and 17e1feb.

📒 Files selected for processing (1)

• app/(app)/articles/_client.tsx (1 hunks)

🔇 Additional comments (1)

app/(app)/articles/_client.tsx (1)

Line range hint 1-224: Overall assessment: Changes effectively address the dark mode issue.

The modifications in this file are minimal and focused, successfully addressing the issue of the dropdown menu appearing in light mode when the page is in dark mode. The changes are consistent with the existing codebase and do not introduce any new issues or affect other functionality.

The PR objectives have been met, and the implementation aligns well with the requirements outlined in the linked issue #1063.

[NiallJoeMaher]

This is great! Would you be able to fix the profile menu on mobile too with this fix? Thanks!

[nawinsharma]

@NiallJoeMaher done with the changes, LMK if there are more to be fixed?

Screencast.from.2024-10-06.02-18-55.webm

[NiallJoeMaher]

Thanks! I'll scout through the screens to see if there are any more but let's get this merged! Well done.
The only thing left is to run npm run prettier:fix to cleanup a lint issue in the tabs component.

[nawinsharma]

@NiallJoeMaher fixed the lint issue!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
codu	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 9:15pm

[NiallJoeMaher]

LGTM! 🌮 🦖