Skip to content

Fix/name change - #68

Merged
ieliofficial merged 3 commits into
mainfrom
fix/name-change
Jul 16, 2026
Merged

ieliofficial merged 3 commits into
mainfrom
fix/name-change

Conversation

@DevOlabode

Copy link
Copy Markdown
Member

Change the name from "Equalview" to "Vizably"

@DevOlabode DevOlabode self-assigned this Jul 10, 2026
@DevOlabode DevOlabode linked an issue Jul 10, 2026 that may be closed by this pull request
30 tasks
@DevOlabode
DevOlabode requested a review from ieliofficial July 12, 2026 01:43

@ieliofficial ieliofficial left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am requesting changes because this branch is not safe to merge yet:

  1. The committed GitHub App private key (equalview-test.2026-07-10.private-key.pem) is still on this branch. If you have not already rotated it after our earlier chat, please generate a new key now. Either way it still needs to come out: remove it from the branch history and add a private-key ignore rule, since deleting it in a later commit does not remove it from history.
  2. Please resolve all remaining conflict markers. They are currently present in backend and frontend source files, tests, and docs, so the project cannot build as submitted.
  3. Please rebuild this as a rename-only PR from the latest clean base. The authentication and storage changes should remain in their separate PR.
  4. Keep compatibility with existing equalview.json account stores, or add a tested migration, so current users do not lose access to saved scans.

One more small thing for the redo: the replace lowercased the brand in a few places (page title, headings, prose), so it reads "vizably" instead of "Vizably". Keep the capital V in sentences and titles, and lowercase only real identifiers like vizably.json.

The simplest path is to start a fresh branch after the auth work is settled, apply only the branding changes, then run the backend tests and frontend test, lint, and build checks.

And no worries if key handling is fiddly, this stuff trips everyone up early on. If necessary, I walk you through a setup that takes the manual key juggling off your plate and is safer by default.

@DevOlabode DevOlabode linked an issue Jul 13, 2026 that may be closed by this pull request
@DevOlabode
DevOlabode force-pushed the fix/name-change branch 2 times, most recently from b82653a to 1f8295d Compare July 13, 2026 06:54
@DevOlabode
DevOlabode requested a review from ieliofficial July 13, 2026 07:28
@ieliofficial

Copy link
Copy Markdown
Member

Thanks for clearing the conflict markers and fixing most of the capitalization.

On the private key: the good news is you don't need to rewrite history for this. Instead, rotate the key you committed. Go into the GitHub App settings, generate a new private key, and delete the one from commit 6cf5938 so the exposed one stops working. Update wherever it's used (the GITHUB_APP_PRIVATE_KEY env value). Once the old key is revoked, the copy left in history is harmless. It's in .gitignore now too, so just keep credentials out of commits from here on.

Two things left before this can merge:

  • This should be the rename only, but it's also carrying auth and storage changes (authService, storageService, ConnectView, scanController and their tests). Those belong in Feature/authentication/phase2 #66. Please pull them out so this stays a clean rename.
  • The manifest is now vizably.json and the loader requires manifest.vizably === true with no fallback, so any existing equalview.json account would stop loading. Have the loader accept equalview.json too (or add a small migration), and add a test for it.

Small one: the brand SVGs still have aria-label="vizably" in lowercase, so screen readers announce the old name. Quick fix, and worth doing given what we build.

Keep this branch rename-only: drop Phase 2 auth/storage behavior that
belonged on feature/authentication/phase2.

Co-authored-by: Cursor <cursoragent@cursor.com>

@ieliofficial ieliofficial left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now.

Resolves conflicts by keeping main's Phase 2 code and reapplying the
Vizably rename on top: ConnectView, AccountView, placeholders, backend
user-facing messages, backend README, and test assertions. Keeps the
equalview.json legacy fallback and migration tests untouched.
@ieliofficial
ieliofficial merged commit cb1a8e4 into main Jul 16, 2026
@ieliofficial
ieliofficial deleted the fix/name-change branch July 16, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename repo to Vizably Change the name of the project from "Equalview" to " Vizably"

2 participants