Repository navigation
Fix/name change - #68
Conversation
e5abf88 to
a3dd374
Compare
ieliofficial
left a comment
There was a problem hiding this comment.
I am requesting changes because this branch is not safe to merge yet:
- The committed GitHub App private key (
equalview-test.2026-07-10.private-key.pem) is still on this branch. If you have not already rotated it after our earlier chat, please generate a new key now. Either way it still needs to come out: remove it from the branch history and add a private-key ignore rule, since deleting it in a later commit does not remove it from history. - Please resolve all remaining conflict markers. They are currently present in backend and frontend source files, tests, and docs, so the project cannot build as submitted.
- Please rebuild this as a rename-only PR from the latest clean base. The authentication and storage changes should remain in their separate PR.
- Keep compatibility with existing
equalview.jsonaccount stores, or add a tested migration, so current users do not lose access to saved scans.
One more small thing for the redo: the replace lowercased the brand in a few places (page title, headings, prose), so it reads "vizably" instead of "Vizably". Keep the capital V in sentences and titles, and lowercase only real identifiers like vizably.json.
The simplest path is to start a fresh branch after the auth work is settled, apply only the branding changes, then run the backend tests and frontend test, lint, and build checks.
And no worries if key handling is fiddly, this stuff trips everyone up early on. If necessary, I walk you through a setup that takes the manual key juggling off your plate and is safer by default.
b82653a to
1f8295d
Compare
|
Thanks for clearing the conflict markers and fixing most of the capitalization. On the private key: the good news is you don't need to rewrite history for this. Instead, rotate the key you committed. Go into the GitHub App settings, generate a new private key, and delete the one from commit 6cf5938 so the exposed one stops working. Update wherever it's used (the GITHUB_APP_PRIVATE_KEY env value). Once the old key is revoked, the copy left in history is harmless. It's in .gitignore now too, so just keep credentials out of commits from here on. Two things left before this can merge:
Small one: the brand SVGs still have aria-label="vizably" in lowercase, so screen readers announce the old name. Quick fix, and worth doing given what we build. |
Keep this branch rename-only: drop Phase 2 auth/storage behavior that belonged on feature/authentication/phase2. Co-authored-by: Cursor <cursoragent@cursor.com>
3d797b7 to
184cbae
Compare
Resolves conflicts by keeping main's Phase 2 code and reapplying the Vizably rename on top: ConnectView, AccountView, placeholders, backend user-facing messages, backend README, and test assertions. Keeps the equalview.json legacy fallback and migration tests untouched.
Change the name from "Equalview" to "Vizably"