Repository navigation
feat(AccountView): add data export functionality for JSON and PDF for… - #129
Open
DevOlabode wants to merge 5 commits into
Open
DevOlabode wants to merge 5 commits into
DevOlabode wants to merge 5 commits into
Conversation
ieliofficial
requested changes
Sep 30, 2026
ieliofficial
left a comment
ieliofficial
left a comment
Member
There was a problem hiding this comment.
The export looks good, and loading jsPDF only when it's needed is the right call. Two things. It fetches every saved scan at the same time, and each one costs at least six GitHub calls because it mints a fresh app token first, so a big account can hit the rate limit. Please fetch a few at a time. And when some scans fail they end up as error rows inside the file with nothing on screen, so tell the user something like 94 of 100 exported.
…porting and concurrency control
…cans and add corresponding test
DevOlabode
force-pushed
the
feat/download-my-data
branch
from
September 30, 2026 19:24
0103400 to
a6c510f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #109