Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Review for 1st Iteration of E-commerce App - Two Tired Gears #1

Open
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

codingwolf-at
Copy link
Owner

Name: Atul Tameshwari
Live Link : https://two-tired-beta.netlify.app/

Note:

  1. Kindly excuse the styling and inconsistent CSS, everything from cards, buttons, icon buttons, and pages will be worked upon in coming iterations.
  2. I am not using Mirage.
  3. The second iteration will include :
    • React Router v6
    • Auth, login & sign up pages
    • Landing Page

@Xdev200
Copy link

Xdev200 commented Apr 11, 2021

Like the brand logo

some suggestion:

  1. Remove the shadow from the product add the shadow on hover

Troubleshoot:

  1. On the product page align the buttons.
  2. wishlist button should function as a toggle but currently, it is not.
  3. in cart item count is going negative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants