Skip to content

Latest commodities #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 9, 2019
Merged

Latest commodities #739

merged 9 commits into from
Nov 9, 2019

Conversation

pnemonic78
Copy link
Contributor

fixes #731

Copied the latest currencies XML file from the GnuCash desktop version with correct IRR symbol.
This requires a re-population of the commodities database table.

codinguser
codinguser reviewed Nov 17, 2017
View reviewed changes
app/src/main/java/org/gnucash/android/importer/CommoditiesXmlHandler.java
@@ -82,6 +82,7 @@ public void startElement(String uri, String localName, String qName, Attributes

@Override
public void endDocument() throws SAXException {
mCommoditiesDbAdapter.deleteAllRecords();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this call? Aren't we always importing into a new book anyway? (which means a fresh database)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, an existing book that will have its database "upgraded" means that the table is already populated with commodities, so we need to delete the old ones and populate from the latest xml.

@codinguser
Copy link
Owner

Thanks for the PR @pnemonic78
I have a couple of remarks:

  1. I would prefer to do a database migration only in develop branch as far as is possible. Hotfix db migrations should only be for burning issues.
  2. Please in the future separate refactorings and feature/bugfix pull requests. This PR makes many modifications which are unrelated to the main goal of the PR and that makes it hard to understand where the actual fixes are.
  3. I do not see the new currencies XML in the list of changed files. Where is it saved?
  4. I also added a question to the PR itself (you should have gotten a notification).

Cheers,

@codinguser
Copy link
Owner

Thanks for the PR @pnemonic78
I have a couple of remarks:

  1. I would prefer to do a database migration only in develop branch as far as is possible. Hotfix db migrations should only be for burning issues. Could you please reissue this against develop?
  2. Please in the future separate refactorings and feature/bugfix pull requests. This PR makes many modifications which are unrelated to the main goal of the PR and that makes it hard to understand where the actual fixes are.
  3. I do not see the new currencies XML in the list of changed files. Where is it saved?
  4. I also added a question to the PR itself (you should have gotten a notification).

Cheers,

@pnemonic78
Copy link
Contributor Author

pnemonic78 commented Nov 19, 2017 •
edited
Loading

  1. will re-do in develop
  2. ok, next time.
  3. c375478
  4. answered above.

@pnemonic78 pnemonic78 changed the base branch from hotfix/patches to develop November 19, 2017 07:35
@pnemonic78
Copy link
Contributor Author

ready for approval :-)

@codinguser
Copy link
Owner

Just to note that I didn't forget this. I will merge it into develop for the release after 2.4.0 (currently in beta)

@codinguser codinguser merged commit bbabd3b into codinguser:develop Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codinguser codinguser codinguser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnemonic78 @codinguser