-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix 641: Weekday is ignored in scheduled exports #680
Bugfix 641: Weekday is ignored in scheduled exports #680
Conversation
The actions were run just once per week without taking into account the weekdays set by the user. Fixes codinguser#641
No, it's not late. I just wanted to get a first beta out as soon as
possible so we can get actual user feedback.
I'll check it when I get back to my desk. Thanks!
…On Tue 25. Apr 2017 at 19:40, Àlex Magaz Graça ***@***.***> wrote:
Am I late for 2.2?
Please, check I haven't missed any corner case :)
------------------------------
You can view, comment on, or merge this pull request online at:
#680
Commit Summary
- Take into account weekdays on weekly scheduled actions
File Changes
- *M* app/src/main/java/org/gnucash/android/model/ScheduledAction.java
<https://github.com/codinguser/gnucash-android/pull/680/files#diff-0>
(40)
- *M*
app/src/test/java/org/gnucash/android/test/unit/model/ScheduledActionTest.java
<https://github.com/codinguser/gnucash-android/pull/680/files#diff-1>
(46)
Patch Links:
- https://github.com/codinguser/gnucash-android/pull/680.patch
- https://github.com/codinguser/gnucash-android/pull/680.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#680>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAQ4285RNyNAwFWiSb0V4vwSdCTEW9mEks5rzjAagaJpZM4NH0ip>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, thanks.
Could you please check the failing tests on Travis though?
Do the tests need updating, or does the code break something?
Sorry, I forgot to switch back to the full unit test suite before sending the pull request. It seems the tests have to be updated to set Today I have a busy day. I'll fix it tomorrow. |
It should be fixed now. |
Cool, thanks. So |
Yes, the dialog forces you to set at least on weekday. However, after a more thorough inspection, I've found Until we don't implement the parsing for imported weekly transaction, I'd add at least one weekday to Also, although with a warning, GnuCash desktop allows you to define a weekly transaction without setting any weekday. In that case, it's never executed. So, I'll have to add a check for empty |
@rivaldi8 sounds like a plan 👍 |
Am I late for 2.2?
Please, check I haven't missed any corner case :)