Avoid Price.toString() failing for certain values of numerator/denominator. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nator. Fixes a regression introduced in 66cc533 (bugfix codinguser#479) in which the numerator/denominator division fails with an ArithmeticException if no MathContext is provided. BigDecimal tries to return an exact result, which is not possible when rounding and precision aren't specified. See BigDecimal javadoc: http://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html Fixes Crashlitics issue codinguser#196 https://fabric.io/gnucash/android/apps/org.gnucash.android/issues/571b4a95ffcdc04250f98ba0
| @@ -4,7 +4,7 @@ buildscript { | |||
| jcenter() | |||
| } | |||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:1.5.0' | |||
| classpath 'com.android.tools.build:gradle:2.0.0' | |||
There was a problem hiding this comment.
@rivaldi8 Thanks for the pr.
This version upgrade breaks the build, because it depends on a higher version of gradle.
We will upgrade for the 2.1.x series. But 2.0.x should stay with build tools 1.5.0
rivaldi8
force-pushed
the
fix-arithmeticexception-in-price
branch
from
469314a
to
fd7007e
Compare
|
Ok, I've updated the pull request dropping the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in 66cc533 (bugfix #479) in which the numerator/denominator division fails with an
ArithmeticExceptionif noMathContextis provided. Somehow I missed it when moving code around.Fixes Crashlitics issue #196