Feature/andre floquet #37
Conversation
| if(isset($post)) { | ||
| session()->flash('success', "The post '{$post->name}' has been created!"); | ||
| } |
There was a problem hiding this comment.
If the Post::create() operation failed an exception would be thrown, so this if condition is unnecessary.
There was a problem hiding this comment.
Yeah, I agree. Would be better in a try catch block
There was a problem hiding this comment.
changed for try catch block returning friendly user message
| { | ||
| Schema::create('posts', function (Blueprint $table) { | ||
| $table->id(); | ||
| $table->foreignId('user_id')->constrained()->cascadeOnDelete(); |
There was a problem hiding this comment.
I think this means if the post is deleted, the user is also deleted? 😱
There was a problem hiding this comment.
actually no, this looks correct.
There was a problem hiding this comment.
yeah, the opposite. If the user is deleted, the posts from the user are deleted too
resources/views/home.blade.php
Outdated
| <div> | ||
| <x-label for="image" :value="__('Upload Image')" /> | ||
|
|
||
| <x-input-file id="image" class="block mt-1 w-full" type="file" name="image" /> |
There was a problem hiding this comment.
I'd probably move type="file" to the file component given it is specifically a file component.
There was a problem hiding this comment.
Indeed. I saw the input component and I copied from that as I have no much experience working with blade components, but the input can be of many types, the file input type is just file input type. You are right.
fix on input-file component and post.store. Add images .gitignore
Create Post