fix deepcopy & pickle for unsaved model instances & empty image fields#324
Merged
codingjoe merged 2 commits intocodingjoe:masterfrom Nov 6, 2023
Merged
Conversation
|
I came here to report this exact issue after scratching my head for over a year :) If this can be accepted and released, that would be amazing! |
syphar
force-pushed
the
fix-deepcopy-and-pickle
branch
from
bb579ad to
1cde8d2
Compare
Author
|
@codingjoe I forgot about your comment to finish this up, sorry for the delay. I removed the unused import & rebased on master. |
codingjoe
approved these changes
Nov 6, 2023
Owner
codingjoe
left a comment
codingjoe
left a comment
There was a problem hiding this comment.
More, broken things in the CI suite. Anyhow, I tested it locally. I will release this change.
|
@codingjoe thanks for the quick fix, much appreciated :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to upgrade to v6 of this library we stumbled onto what we think is a bug.
When trying to
deepcopy, orpicklean model instance that:NoneThen the
__getstate__implementation will break since the descriptor doesn't include the variations.This was broken since #265, and released in 5.3.3 (I think).
I understand if this would be not seen as a bug, or not being merged because this library is unmaintained, then we would probably fork it and use the fork until we fully migrated.