Skip to content

inactive #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 83 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,92 @@

# Django Standardized Image Field

This package has been deprecated in favor of [django-pictures][django-pictures].

## Migration Instructions

First, make sure you understand the differences between the two packages and
how to serve images in a modern web application via the [picture][picture-tag]-Element.

Next, follow the setup instructions for [django-pictures][django-pictures].

Once you are set up, change your models to use the new `PictureField` and provide the
`aspect_ratios` you'd like to serve. Do create migrations just yet.

This step should be followed by changing your templates and frontend.
The new placeholders feature for local development should help you
to do this almost effortlessly.

Finally, run `makemigrations` and replace the `AlterField` operation with
`AlterPictureField`.

We highly recommend to use Django's `image_width` and `image_height` fields, to avoid
unnecessary IO. If you can add these fields to your model, you can use the following
snippet to populate them:

```python
import django.core.files.storage
from django.db import migrations, models
import pictures.models
from pictures.migrations import AlterPictureField

def forward(apps, schema_editor):
for obj in apps.get_model("my-app.MyModel").objects.all().iterator():
obj.image_width = obj.logo.width
obj.image_height = obj.logo.height
obj.save(update_fields=["image_height", "image_width"])

def backward(apps, schema_editor):
apps.get_model("my-app.MyModel").objects.all().update(
image_width=None,
image_height=None,
)

class Migration(migrations.Migration):
dependencies = [
('my-app', '0001_initial'),
]

operations = [
migrations.AddField(
model_name="mymodel",
name="image_height",
field=models.PositiveIntegerField(editable=False, null=True),
),
migrations.AddField(
model_name="mymodel",
name="image_width",
field=models.PositiveIntegerField(editable=False, null=True),
),
migrations.RunPython(forward, backward),
AlterPictureField(
model_name="mymodel",
name="image",
field=pictures.models.PictureField(
aspect_ratios=["3/2", "3/1"],
breakpoints={"desktop": 1024, "mobile": 576},
container_width=1200,
file_types=["WEBP"],
grid_columns=12,
height_field="image_height",
pixel_densities=[1, 2],
storage=django.core.files.storage.FileSystemStorage(),
upload_to="pictures/",
verbose_name="image",
width_field="image_width",
),
),
]
```

[django-pictures]: https://github.com/codingjoe/django-pictures
[picture-tag]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture

## Why would I want this?

This is a drop-in replacement for the [Django ImageField](https://docs.djangoproject.com/en/1.8/ref/models/fields/#django.db.models.ImageField) that provides a standardized way to handle image uploads.
It is designed to be as easy to use as possible, and to provide a consistent interface for all image fields.
It allows images to be presented in various size variants (eg:thumbnails, mid, and hi-res versions)
It allows images to be presented in various size variants (eg:thumbnails, mid, and hi-res versions)
and it provides a way to handle images that are too large with validators.


Expand Down Expand Up @@ -103,7 +184,7 @@ You can use a function for the `upload_to` argument. Using [Django Dynamic Filen

This allows images to be given unique paths and filenames based on the model instance.

Example
Example

```python
from django.db import models
Expand Down
4 changes: 2 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ url = https://github.com/codingjoe/django-stdimage
license = MIT
license_file = LICENSE
classifier =
Development Status :: 5 - Production/Stable
Development Status :: 7 - Inactive
Environment :: Web Environment
Framework :: Django
Topic :: Multimedia :: Graphics :: Graphics Conversion
Expand Down Expand Up @@ -63,7 +63,7 @@ norecursedirs=venv env .eggs
DJANGO_SETTINGS_MODULE=tests.settings
addopts = --cov=stdimage --nomigrations --tb=short
filterwarnings =
error
ignore::DeprecationWarning

[coverage:run]
source = .
Expand Down
9 changes: 9 additions & 0 deletions stdimage/models.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import logging
import os
import warnings
from io import BytesIO

from django.core.files.base import ContentFile
Expand All @@ -18,6 +19,14 @@
logger = logging.getLogger()


warnings.warn(
"The django-stdimage is deprecated in favor of django-pictures.\n"
"Migration instructions are available in the README:\n"
"https://github.com/codingjoe/django-stdimage#migration-instructions",
DeprecationWarning,
)


class StdImageFileDescriptor(ImageFileDescriptor):
"""The variation property of the field is accessible in instance cases."""

Expand Down