Skip to content

Add clarification about widget types #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

WoosterInitiative
Copy link

Help users save time in the event that they're trying to use these extra features with a light widget where it will not work.

Help users save time in the event that they're trying to use these extra features with a light widget where it will not work.
@codingjoe codingjoe self-requested a review August 6, 2022 09:48
@codingjoe codingjoe added the documentation Improvements or additions to documentation label Aug 6, 2022
Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WoosterInitiative,

Thanks the pull-request. I always appreciate people improving the documentation.

Reading your change I notice, maybe documenting the "light" widgets does more harm than it does good. I always felt, the abstract inheritance structure is very difficult.

I'm not saying you should fix all that in your pull-request. I'm just curious to get your input on that.

Cheers,
Joe

@WoosterInitiative
Copy link
Author

Not sure why I didn't see a notification for this I'll give it some thought. Thanks for the feedback.

@WoosterInitiative
Copy link
Author

@codingjoe

I always felt, the abstract inheritance structure is very difficult.

I guess I'm not quite sure what you mean by that. Because it's been a while (my fault), I don't remember exactly which fields I was wishing to do this with, so I don't remember the context, but I do remember my frustration. This page makes it feel like I should be able to chain any two select2 fields, so I spent a considerable amount of time trying to do so, thinking I was making some silly mistake (as is so often, so very, very often, the case), only to discover that I was trying to do something that wasn't possible.

I'm not able to see the harm yet.

@codingjoe codingjoe merged commit 7215346 into codingjoe:main Oct 27, 2022
@codingjoe
Copy link
Owner

@WoosterInitiative never mind then. It's a good improvement to the docs, we don't need to make it anymore complicated. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants