-
-
Notifications
You must be signed in to change notification settings - Fork 4
Add anonymization feature for private user data #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d704a36 to
2c6cf29
Compare
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 99.68% 96.97% -2.71%
==========================================
Files 18 23 +5
Lines 316 364 +48
==========================================
+ Hits 315 353 +38
- Misses 1 11 +10
Continue to review full report at Codecov.
|
1c3a649 to
6dd1f48
Compare
herrbenesch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codingjoe nice feature.
I think the real blockers hereare that you are using digest as well as hexdigest for a field you want to filter on and that you are not populating the new hash field. Which, I guess, is something you want.
I surely can't know all the implications this change will have on actual usage. Perhaps we should once install it @ voiio platform and test.
mailauth/contrib/user/migrations/0005_emailuser_email_hash_alter_emailuser_email.py
Outdated
Show resolved
Hide resolved
mailauth/contrib/user/migrations/0005_emailuser_email_hash_alter_emailuser_email.py
Outdated
Show resolved
Hide resolved
d3e3f2e to
c0b8808
Compare
|
@Fidelitas I decided to ditch the whole hash thing. Hash collisions are an unlikely problem, but there really is no need to retain a hash. So just anonymization now :) |
4eeb9c4 to
16f38aa
Compare
|
This pull request introduces 1 alert when merging 16f38aa into 8d3634e - view on LGTM.com new alerts:
|
5a2d691 to
03cfcad
Compare
|
This pull request introduces 1 alert when merging 03cfcad into 8d3634e - view on LGTM.com new alerts:
|
herrbenesch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really impressed of the clean code (also the tests) that has been made here.
Very well done!
mailauth/contrib/user/migrations/0005_emailuser_email_hash_alter_emailuser_email.py
Outdated
Show resolved
Hide resolved
|
This pull request introduces 1 alert when merging 3c2ffe0 into 8d3634e - view on LGTM.com new alerts:
|
9994856 to
905eca7
Compare
e8ede25 to
8868e3d
Compare
|
This pull request introduces 1 alert when merging 8868e3d into afa829f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging fa125e9 into afa829f - view on LGTM.com new alerts:
|
User privacy is important, not only to meet local regulations, but also to
protect your users and allow them to exercise their rights. However,
it's not always practical to delete users, especially if they have dependent
objects, that are relevant for statistical analysis.
Anonymization is a process of removing the user's personal data whilst keeping
related data intact. This is done by using the
anonymizemethod.