Skip to content

Add _legacy_get_session_auth_hash to fix Django 3.1 support #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2020
Merged

Add _legacy_get_session_auth_hash to fix Django 3.1 support #18

merged 1 commit into from
Aug 12, 2020

Conversation

@codingjoe
Copy link
Owner

@codingjoe codingjoe commented Aug 12, 2020

No description provided.

@codingjoe codingjoe force-pushed the django31 branch 2 times, most recently from a96554f to 78c2e2a Compare August 12, 2020 06:07
@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2020

This pull request introduces 1 alert when merging 78c2e2a into becd3b7 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@codingjoe codingjoe force-pushed the django31 branch 2 times, most recently from 4ce280d to 17eef7d Compare August 12, 2020 07:33
@codecov
Copy link

codecov bot commented Aug 12, 2020 •
edited
Loading

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        17    +1     
  Lines          248       273   +25     
=========================================
+ Hits           248       273   +25
Impacted Files Coverage Δ
mailauth/backends.py 100.00% <100.00%> (ø)
mailauth/contrib/admin/views.py 100.00% <100.00%> (ø)
...rib/user/migrations/0002_emailuser_session_salt.py 100.00% <100.00%> (ø)
...contrib/user/migrations/0004_auto_20200812_0722.py 100.00% <100.00%> (ø)
mailauth/contrib/user/models.py 100.00% <100.00%> (ø)
mailauth/signing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becd3b7...112c81c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2020

This pull request introduces 1 alert when merging 17eef7d into becd3b7 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@codingjoe codingjoe force-pushed the django31 branch 6 times, most recently from 84eeb6d to 7d66806 Compare August 12, 2020 09:38
@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2020

This pull request introduces 1 alert when merging 7d66806 into becd3b7 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2020

This pull request introduces 1 alert when merging 8d44e96 into becd3b7 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2020

This pull request introduces 1 alert when merging b4fa818 into becd3b7 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2020

This pull request introduces 1 alert when merging 112c81c into becd3b7 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@codingjoe codingjoe merged commit 7684d0b into master Aug 12, 2020
@codingjoe codingjoe deleted the django31 branch August 12, 2020 13:44
amureki added a commit that referenced this pull request Oct 14, 2022
@amureki
Drop Django 3.1 related code
5ff88d6 
This PR drops code introduced in #18 to support Django 3.1:
https://docs.djangoproject.com/en/4.1/releases/3.1/#default-hashing-algorithm-settings

Since Django 3.1 support is gone, shall we get rid of this code?
@amureki amureki mentioned this pull request Oct 14, 2022
Merged
amureki added a commit that referenced this pull request Oct 14, 2022
@amureki
Drop Django 3.1 related code
0658203 
This PR drops code introduced in #18 to support Django 3.1:
https://docs.djangoproject.com/en/4.1/releases/3.1/#default-hashing-algorithm-settings

Since Django 3.1 support is gone, shall we get rid of this code?
amureki added a commit that referenced this pull request Oct 17, 2022
@amureki
Drop Django 3.1 related code (#75)
57fe5b5 
This PR drops code introduced in #18 to support Django 3.1:
https://docs.djangoproject.com/en/4.1/releases/3.1/#default-hashing-algorithm-settings

Since Django 3.1 support is gone, shall we get rid of this code?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codingjoe