Get rid of unicode-slugify extras #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/mozilla/unicode-slugify handles úmlauts similarly to django internal slugify script: https://docs.djangoproject.com/en/4.1/_modules/django/utils/text/#slugify We do not really need to have this extras, but can stick to a Django option.
|
@codingjoe could you, please, trigger CI here? 😇 |
nschlemm
reviewed
Oct 7, 2022
| @@ -41,7 +41,6 @@ tests_require = | |||
|
|
|||
| [options.extras_require] | |||
| slugify = | |||
There was a problem hiding this comment.
sorry for asking, but is there a reason to keep the empty extra requirement?
There was a problem hiding this comment.
The intention was to not break the installation right away in case someone was using slugify as extra dependency. But maybe it is actually better to get rid of it completely.
@nschlemm is this causing you issues, or it is just your observation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mozilla/unicode-slugify handles ümlauts similarly to Django internal slugify script: https://docs.djangoproject.com/en/4.1/_modules/django/utils/text/#slugify
We do not really need to have this extras, but can stick to a Django option.