Skip to content

定义 initialize 阶段;解决平台与开源版 API 分叉问题 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 6, 2017

Conversation

hackape
Copy link
Contributor

@hackape hackape commented Mar 6, 2017

  1. 定义 initialize 阶段,把主要的初始化工作都移入 intialize.js 文件集中进行。现在利用 step util function 强制这个初始化过程是串行的,这样比较符合初始化的业务需求,也方便之后做初始化进度条。

  2. 整理了平台版与开源版由于 API 差异造成的逻辑分叉,统一用 if (config.isPlatform) 来标记这些差异,下一步或由后端改 API 来尽量磨平这些差异。同时把原先开源版上 workspaces list 的页面分出来自己成一个 entry point,以求跟平台版统一。

hackape and others added 6 commits March 2, 2017 16:22
…t as below:

Centralize most initialization works, also some adjustment done to webpack configs and request.js, finish merging platform-api branch

:fire: remove ace editor related codes

Fix process.env

Fix webpack config

Fix scrollbar style

Fix web socket

Add a switch version button

:hammer: introcude initialize lifecycle stage to app
@hackape hackape requested a review from KevenYoung March 6, 2017 02:25
@hackape
Copy link
Contributor Author

hackape commented Mar 6, 2017

补充:

  1. 引入 .dot 机制来解决开发时候环境变量的设定
  2. 移除了 ace 依赖

这个 pr 同时包含了杨臻做的 platform-api 分支,因为要抹掉开发参数历史的关系,相关 commit 被 squash 了. 内容包含:

  1. 平台版 tty websocket 调通
  2. scrollbar 在 editor 内 re-enable
  3. 给平台版加了“切换新版”按钮

@hackape hackape merged commit f68ef39 into master Mar 6, 2017
@hackape hackape deleted the define-app-lifecycle branch March 7, 2017 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant