增加插件系统的开发支持 #56
Merged
增加插件系统的开发支持 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackape
reviewed
Feb 27, 2017
| @@ -13,7 +13,7 @@ const defaultRequestOptions = { | |||
| const defaultFetchOptions = { | |||
| method: 'GET', | |||
| mode: 'cors', | |||
| credentials: 'include', | |||
| credentials: __DEV__ ? '' : 'include', | |||
webpack_configs/devServer.config.js
Outdated
| }) | ||
| }), | ||
| new webpack.DefinePlugin({ | ||
| __PACKAGE__: JSON.stringify(process.env.PACKAGE_SERVER || ''), |
There was a problem hiding this comment.
为什么不直接叫 PACKAGE_SERVER？或者 PACKAGE_URL，只是 PACAKGE 的话感觉语义上不清晰
app/components/Package/reducer.js
Outdated
| if (extensionIds.includes(pkgId) === pkg.enabled) return state | ||
|
|
||
| return update(state, { | ||
| const res = update(state, { |
app/backendAPI/packageAPI.js
Outdated
| @@ -1,8 +1,14 @@ | |||
| /* @flow weak */ | |||
| import { request } from '../utils' | |||
| import config from '../config' | |||
| const packageServer = config.packageServer | |||
|
|
|||
| const { packageServer, extensionServer } = config | |||
app/backendAPI/packageAPI.js
Outdated
| export const fetchPackageInfo = (pkgName) => request.get(`${packageServer}/packages/${pkgName}`) | ||
| export const fetchPackageScript = (pkgName) => request.get(`${packageServer}/packages/${pkgName}/download`) | ||
| export const fetchPackageInfo = (pkgName) => | ||
| request.get(`${packageServer}/packages/${pkgName}`) |
app/backendAPI/packageAPI.js
Outdated
| export const fetchPackageInfo = (pkgName) => | ||
| request.get(`${packageServer}/packages/${pkgName}`) | ||
| export const fetchPackageScript = (pkgName, debugServer) => { | ||
| if (debugServer) { |
There was a problem hiding this comment.
现在 debugServer 的情况 ok 了，那生产的情况是怎么考虑的？
There was a problem hiding this comment.
生产情况放其他mr，等待和后端协调接口
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加插件系统开发支持