Zhenjieruan/codemirror #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2016 03:05
… css, becuase every theme for codemirror is essetially a css file 2) autocompletion, looks like we need to implement this ourself, even the basic one(eg. completion in the same file).
Merged
hackape
added a commit
that referenced
this pull request
Dec 20, 2016
Substitute CodeMirror for Ace as text editor. This PR is base on #43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems remaining: 1) rule for including css, cause every theme for codemirror is essentially a css file and I can't find a way to load css on the fly 2) autocompletion, looks like we need to implement this ourself, even the basic one(eg. completion in the same file).