Skip to content

Zhengxinqi/markdown preview #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 23, 2016
Merged

Zhengxinqi/markdown preview #26

merged 5 commits into from
Nov 23, 2016

Conversation

hackape
Copy link
Contributor

@hackape hackape commented Nov 23, 2016

No description provided.

) : null)
}
{!showPreview ? <i className='fa fa-eye' style={{marginLeft: '10px', color: '#999'}} onClick={actions.togglePreview}></i> :
<i className='fa fa-eye-slash' style={{ marginLeft: '10px', color: '#999' }}onClick={actions.togglePreview}></i>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onClick 前面加空格?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bluishoul code style 问题之后统一修,刚把 eslint 加上

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackape 可以顺便把 CI 加上 😈

height: '100%'
}}>
<div name="toolbal_commands" style={{
position: 'absolute',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进似乎有点问题

@hackape hackape merged commit 5fb4c72 into master Nov 23, 2016
@hackape hackape deleted the zhengxinqi/markdown_preview branch March 7, 2017 03:14
KevenYoung pushed a commit that referenced this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants