Add git stash, unstash and reset. #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vangie
requested changes
Oct 31, 2016
| } | ||
| } | ||
|
|
||
| export const GIT_UPDATE_UNSTASH_IS_REINSTATE= 'GIT_UPDATE_UNSTASH_IS_REINSTATE' |
| } | ||
| } | ||
|
|
||
| export const GIT_UPDATE_UNSTASH_BRANCH_NAME= 'GIT_UPDATE_UNSTASH_BRANCH_NAME' |
| } | ||
|
|
||
| handleConfirm (e) { | ||
| console.log('handleConfirm') |
| } | ||
|
|
||
| handleChangeOption (e) { | ||
| console.log('handleChangeOption') |
|
@vangie 已经修改了 |
|
LGTM |
vangie
approved these changes
Oct 31, 2016
hackape
reviewed
Nov 1, 2016
| @@ -1,7 +1,7 @@ | |||
| /* @flow weak */ | |||
| import api from '../../api' | |||
| import { notify } from '../Notification/actions' | |||
| import { dismissModal } from '../Modal/actions' | |||
| import { notify, error } from '../Notification/actions' | |||
There was a problem hiding this comment.
error 也太 concise 了...容易有误会，建议改成 notifyError 或者任何更具特征性的命名。
There was a problem hiding this comment.
又或者可以考虑把 notify 函数改成一个能接受 "error" 参数的形式？
| min-width: 600px; | ||
| min-height: 20px; | ||
| padding: 0.75em; | ||
| z-index: z(modal); | ||
| border-radius: 4px; | ||
| background-color: #FFF; | ||
| box-shadow: 0 4px 20px 1px rgba(0, 0, 0, .3); | ||
| } | ||
|
|
||
| h1 |
There was a problem hiding this comment.
选用 stylus 主要是因为它语法包容性高且 package 小不爱出错，但鉴于这是开源项目，希望还是用尽量近似 scss 的语法，不要用缩进语法
|
@KevenYoung 另外，我开始在 state 的其他部分应用 FSA 了，就是 action object 的结构要求写作：{type: string, payload?: any, meta?: any} 的形式。这个 PR 里我就不管了，之后你一边写一边慢慢往这个结构改吧。 |
This was referenced Nov 7, 2016
KevenYoung
pushed a commit
that referenced
this pull request
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stash, unstash and reset in Git menu.