rewrite Tab, Pane and DragAndDrop modules with mobx #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch will create a tab if start typing, like sublime does.
# Conflicts: # app/components/Panel/PanelContent.jsx # app/components/Tab/TabBar.jsx # app/components/Tab/TabContainer.jsx # app/utils/index.js
# Conflicts: # app/components/Tab/TabBar.jsx
used to have issue rendering a correct DOM node for an existing CMEditor intstance, now we just detach the original DOM from its old tab-content-item parent node and insert it to the new.
hackape
force-pushed
the
hackape/tab-group-refine
branch
from
d94cd77 to
618dba6
Compare
# Conflicts: # app/utils/themeManager.js
hackape
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.