Skip to content

fixed highlight #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fixed highlight #374

wants to merge 2 commits into from

Conversation

rahgurung
Copy link
Contributor

closes #366
Removed unwanted blue highlight on focus.

Screenshot from 2020-05-28 20-07-05

@mnb27
Copy link
Contributor

mnb27 commented May 28, 2020

I think removing it is not a solution. We can adjust the ouline.

@rahgurung
Copy link
Contributor Author

How should the final one look like?

@rahgurung
Copy link
Contributor Author

I thought we don't even need it, looks very distracting.

@mnb27
Copy link
Contributor

mnb27 commented May 30, 2020

@championswimmer @hereisnaman The highlight should be removed or adjusted ?

@rahgurung
Copy link
Contributor Author

By the way, adding to this discussion. It is currently not supported in all the browsers to add a radius to the outline. https://stackoverflow.com/questions/5394116/outline-radius
Further, there is already a clicking effect on the button which is sufficient. Let's see what the maintainers have to say.

@championswimmer
Copy link
Contributor

I don't see an issue with whatever it is right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper highlight box
3 participants