Implemented the APIs based on template #15
Conversation
|
Awesome work! |
| KillAll() | ||
| KillContainer(StartedContainer) error | ||
| } | ||
|
|
||
| type Storage interface { |
There was a problem hiding this comment.
Can we move this and other API code to separate file?
There was a problem hiding this comment.
By other API code, do you mean moving the handlers to a separate file too, or just the logic related functions?
There was a problem hiding this comment.
I mean move code with API and storage from manager which control Docker images, networks and containers
There was a problem hiding this comment.
Got it. I'll move the API handlers and storage logic into separate files
| @@ -129,7 +144,29 @@ func (m *CodenireOrchestrator) Boot() (err error) { | |||
| } | |||
|
|
|||
| func (m *CodenireOrchestrator) GetTemplates() []BuiltImage { | |||
| return m.imgs | |||
| templates, err := m.storage.LoadTemplates() | |||
There was a problem hiding this comment.
Currentrly, GetTemplates() need for work Playground and should be connect to running images. So we can do it lately, when all logic with storage wiil be done
There was a problem hiding this comment.
Yeah, that makes sense. We'll update it once the storage logic is complete.
Changes Made:
Notes: