fix and simplify media regexes #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codicocodes
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Thank you very much for this contribution! Very helpful!
Could you add a unit test for this? https://github.com/codicocodes/dotfyle/blob/main/src/lib/server/media/parser.spec.ts
Also could you double check the current tests pass as well, I did not add the unit tests to the pipeline yet I only use them for development specifically for the media matching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the media regex not picking up media URLS with characters in range
0-9+%.Also fixes a apurious range and simplifies a bit.