Implemented version tool #466
Conversation
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=============================================
- Coverage 98.549% 98.086% -0.464%
=============================================
Files 29 30 +1
Lines 3792 3814 +22
=============================================
+ Hits 3737 3741 +4
- Misses 55 73 +18
|
| file_path = ['README.md', 'setup.py'] | ||
|
|
||
| # Walk through directories to add all corresponding files' paths into file_path | ||
| for root, _, files in os.walk('./pydatastructs'): |
There was a problem hiding this comment.
May be we can re-use the following function to list all the files,
There was a problem hiding this comment.
yeah, i see. But the root_path in _list_files doesn't make sense since it will go to '../../cur_file_path'.
So I try to modify the _list_files to pass one more argument, like root_path=None, then we can specify the root_path at will.
Does adding such a modification in _list_files make sense?
There was a problem hiding this comment.
So I try to modify the
_list_filesto pass one more argument, likeroot_path=None, then we can specify the root_path at will.Does adding such a modification in
_list_filesmake sense?
Sounds good to me. _list_files is anyway a private function, so changing its API is not a problem.
| with open(path, 'r') as file: | ||
| data = file.read() | ||
| if origin_version in data: | ||
| data = data.replace(origin_version, new_version) |
|
Sorry for the delay in reviewing. |
Implemented a version tool to update version number everywhere.
For example, we want to change version number from 1.0.1-dev to 1.1.1-alpha
I use grep command to check whether the script works.
References to other Issues or PRs or Relevant literature
Implemented #444
Brief description of what is fixed or changed
Other comments