[WIP] Added Stacks Using Linked List #121

sarthakforwet · 2020-03-03T17:49:26Z

References to other Issues or PRs or Relevant literature

Issue #113

Brief description of what is fixed or changed

I have added linked list implementation of Stacks and working on Linked list implementation of queues as well .

Other comments

czgdp1807 · 2020-03-03T17:59:46Z

Please allow edits from maintainers. See the check box on the right side of the page. Just tick it.

sarthakforwet · 2020-03-03T18:51:33Z

@czgdp1807 How to know on what basis and what is being checked ?
Thank you

czgdp1807 · 2020-03-03T19:09:35Z

@sarthakforwet
I have removed build and dist files from your branch, developer. Please do the following before pushing any commit,

git remote add origin_user https://github.com/sarthakforwet/pydatastructs
git pull origin_user developer
sudo python3 setup.py develop(if you are on linux or something equivalent for windows).
Add your commits
Push to your branch.

Let me know if you face any problems.

czgdp1807 · 2020-03-03T19:10:28Z

CODE_OF_CONDUCT.md

@@ -12,7 +12,7 @@ appearance, race, religion, or sexual identity and orientation.
 ## Our Standards

 Examples of behavior that contributes to creating a positive environment
-include:


Don't make changes to this file.

Please address this.

czgdp1807 · 2020-03-03T19:10:38Z

pydatastructs/miscellaneous_data_structures/linked_stacks.py

+        return self.data
+
+    def peek(self):
+        return self.top.data


Add a new line.

czgdp1807 · 2020-03-03T19:11:00Z

pydatastructs/miscellaneous_data_structures/linked_stacks.py

+
+    # A class to implement Stacks Built over Singly Linked Lists
+
+    def __init__(self):


Use a __new__ method.

czgdp1807 · 2020-03-03T19:11:22Z

pydatastructs/miscellaneous_data_structures/linked_stacks.py

@@ -0,0 +1,24 @@
+from pydatastructs import SinglyLinkedList
+
+class Linked_Stacks:


A better name is LinkedListStack.

czgdp1807 · 2020-03-03T19:12:11Z

Please shift the code to stacks.py in miscellaneous_data_structures.

sarthakforwet · 2020-03-03T20:28:10Z

Okk I understood the points and also shifted my code to stacks.py file .

codecov · 2020-03-04T14:14:30Z

Codecov Report

Merging #121 into master will decrease coverage by 1.494%.
The diff coverage is 25.641%.

@@             Coverage Diff              @@
##           master      #121       +/-   ##
============================================
- Coverage   97.94%   96.446%   -1.495%     
============================================
  Files          20        21        +1     
  Lines        1311      1632      +321     
============================================
+ Hits         1284      1574      +290     
- Misses         27        58       +31

Impacted Files	Coverage Δ
...datastructs/miscellaneous_data_structures/stack.py	`60.256% <25.641%> (-34.616%)`	⬇️
pydatastructs/trees/binary_trees.py	`96.894% <0%> (-0.271%)`	⬇️
pydatastructs/graphs/graph.py	`100% <0%> (ø)`	⬆️
pydatastructs/trees/space_partitioning_trees.py	`97.619% <0%> (ø)`	⬆️
pydatastructs/graphs/__init__.py	`100% <0%> (ø)`	⬆️
pydatastructs/trees/__init__.py	`100% <0%> (ø)`	⬆️
pydatastructs/linear_data_structures/__init__.py	`100% <0%> (ø)`	⬆️
pydatastructs/__init__.py	`100% <0%> (ø)`	⬆️
...datastructs/linear_data_structures/linked_lists.py	`100% <0%> (ø)`	⬆️
pydatastructs/graphs/algorithms.py	`100% <0%> (ø)`
... and 3 more

sarthakforwet · 2020-03-04T14:17:07Z

@czgdp1807 Changes have been made and sucessful so should I close this issue now?

czgdp1807 · 2020-03-04T14:20:56Z

Please keep the issue open until the PR is merged.

build/lib/pydatastructs/miscellaneous_data_structures/stack.py

czgdp1807 · 2020-03-09T12:15:57Z

build/lib/pydatastructs/miscellaneous_data_structures/stack.py

+
+class Linked_Stacks(Stack):
+
+    """Representation of Stack Data Structure using Doubly Linked List


IMO, we can use SinglyLinkedList for stacks.

pydatastructs/miscellaneous_data_structures/stack.py

czgdp1807 · 2020-03-09T12:18:01Z

pydatastructs/miscellaneous_data_structures/stack.py

+    def peek(self):
+        if self.top is not None:
+            return self.top.data
+        return "Stack is empty"


Instead raise a ValueError.

czgdp1807 · 2020-03-09T12:18:32Z

pydatastructs/miscellaneous_data_structures/stack.py

+    def __str__(self):
+        "Used for Printing the Stack"
+        iterator = self.top
+        while iterator is not None:
+            print(iterator.data)
+            iterator = iterator.next


Avoid print statements. Instead return a string.

manaswinidas · 2020-03-13T07:24:06Z

build/lib/pydatastructs/miscellaneous_data_structures/stack.py

+            self.top = self.top.prev
+            return self.data
+        else:
+            raise ValueError


ValueError takes a string argument: https://kite.com/python/answers/how-to-raise-a-valueerror-in-python

Not necessary though.

build/lib/pydatastructs/miscellaneous_data_structures/stack.py

czgdp1807 · 2020-03-16T07:48:40Z

Closing in favour of #152

sarthakforwet and others added 3 commits February 27, 2020 16:36

Update CODE_OF_CONDUCT.md

8a9b9ae

including updates Merge https://github.com/codezonediitj/pydatastructs

c0dee35

Added Stacks Using Linked Lists

0d09164

sarthakforwet and others added 2 commits March 3, 2020 13:55

Updated Linked_Stacks

24aff34

modified gitignore and removed build, dist

59288b1

czgdp1807 reviewed Mar 3, 2020

View reviewed changes

czgdp1807 added gssoc20 miscellaneous_data_structures labels Mar 3, 2020

sarthakforwet added 4 commits March 4, 2020 08:41

Updated stack data structure

9a1e200

Updates

4c06b1c

Updates

279ae00

Removed trailing whitespaces from stack.py

c3305e4

czgdp1807 reviewed Mar 9, 2020

View reviewed changes

build/lib/pydatastructs/miscellaneous_data_structures/stack.py Show resolved Hide resolved

czgdp1807 reviewed Mar 9, 2020

View reviewed changes

pydatastructs/miscellaneous_data_structures/stack.py Show resolved Hide resolved

czgdp1807 reviewed Mar 9, 2020

View reviewed changes

pydatastructs/miscellaneous_data_structures/stack.py Show resolved Hide resolved

czgdp1807 reviewed Mar 9, 2020

View reviewed changes

Updated stack.py

73fadc6

manaswinidas suggested changes Mar 13, 2020

View reviewed changes

Update stack.py

994ac71

czgdp1807 closed this Mar 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Added Stacks Using Linked List #121

[WIP] Added Stacks Using Linked List #121

sarthakforwet commented Mar 3, 2020

czgdp1807 commented Mar 3, 2020

sarthakforwet commented Mar 3, 2020

czgdp1807 commented Mar 3, 2020 •

edited

Loading

czgdp1807 Mar 3, 2020

czgdp1807 Mar 9, 2020

czgdp1807 Mar 3, 2020

czgdp1807 Mar 3, 2020

czgdp1807 Mar 3, 2020

czgdp1807 commented Mar 3, 2020

sarthakforwet commented Mar 3, 2020

codecov bot commented Mar 4, 2020 •

edited

Loading

sarthakforwet commented Mar 4, 2020

czgdp1807 commented Mar 4, 2020

czgdp1807 Mar 9, 2020

czgdp1807 Mar 9, 2020

czgdp1807 Mar 9, 2020

manaswinidas Mar 13, 2020

sarthakforwet Jan 31, 2021

czgdp1807 commented Mar 16, 2020


		# A class to implement Stacks Built over Singly Linked Lists

		def __init__(self):

		@@ -0,0 +1,24 @@
		from pydatastructs import SinglyLinkedList

		class Linked_Stacks:


		class Linked_Stacks(Stack):

		"""Representation of Stack Data Structure using Doubly Linked List

[WIP] Added Stacks Using Linked List #121

[WIP] Added Stacks Using Linked List #121

Conversation

sarthakforwet commented Mar 3, 2020

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

czgdp1807 commented Mar 3, 2020

sarthakforwet commented Mar 3, 2020

czgdp1807 commented Mar 3, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czgdp1807 commented Mar 3, 2020

sarthakforwet commented Mar 3, 2020

codecov bot commented Mar 4, 2020 • edited Loading

Codecov Report

sarthakforwet commented Mar 4, 2020

czgdp1807 commented Mar 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czgdp1807 commented Mar 16, 2020

czgdp1807 commented Mar 3, 2020 •

edited

Loading

codecov bot commented Mar 4, 2020 •

edited

Loading