Skip to content

Fixed a few bugs #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2019
Merged

Fixed a few bugs #23

merged 5 commits into from
Feb 3, 2019

Conversation

arjunmahishi
Copy link
Contributor

There are no breaking changes

@ionicc
Copy link
Member

ionicc commented Feb 3, 2019

Thanks for the contribution @arjunmahishi 😄
Could you attach some screenshots of the changes so we can inspect them more properly.

@arjunmahishi
Copy link
Contributor Author

Sure...

Footer gap fix

old footer
new footer

Console errors

old console

Cards

Old cards
new cards

@ionicc
Copy link
Member

ionicc commented Feb 3, 2019

Alright great work 🛩

@ionicc
Copy link
Member

ionicc commented Feb 3, 2019

@Aniket-Mishra Could you review this?

@ionicc ionicc requested a review from Aniket-Mishra February 3, 2019 08:33
Copy link
Member

@Aniket-Mishra Aniket-Mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @arjunmahishi :)

@ionicc ionicc merged commit 303a222 into codezoned:master Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants