Unique validation with ar.

[jeanali]

Why unique validation does not work with Arabic language, but with English it's OK!

My code in store method:

the database:

[ivanvermeyen]

Hi,

It seems that it is not finding the backslash although both the database value and the search value are the same.
I'm still trying to find out why...

According to this post we need to escape a slash x4 when using a LIKE query, but adding slashes in the test didn't help...

So looking further.

Any ideas are welcome :)

[jeanali]

Exactly, you right in search also( I can not search with Arabic words )

[ivanvermeyen]

I didn't add enough backslashes lol...

$value = str_replace('\\', '\\\\\\\\', $value);

I had to escape the escaped backslashes so the resulting string still contains 4 escaped backslashes...
Nuts.

Commit incoming. 👍

[jeanali]

After upgrading to last version !still does not works

Note: I don't know if you take this or not but there is no only 4 backslashes! Each letter in Arabic store backslashe before it

[ivanvermeyen]

I can't reproduce the issue anymore in my tests...
Can you double check that you have v3.3.2?

This test passes for me:

/** @test */
public function it_handles_backslashes_in_values()
{
    Model::create([
        'slug' => ['ar' => '\u0641\u0626\u0629'],
        'name' => ['ar' => '\u0641\u0626\u0629'],
    ]);

    $rules = [
        'slug.*' => "{$this->rule}:{$this->table}",
        'name.*' => UniqueTranslationRule::for($this->table),
    ];

    $validation = Validator::make([
        'slug' => ['ar' => '\u0641\u0626\u0629'],
        'name' => ['ar' => '\u0641\u0626\u0629'],
    ], $rules);

    $this->assertTrue($validation->fails());
}

[jeanali]

😞

[ivanvermeyen]

Still not working?
Can you give me some more context to work with?
What do your form fields look like?
Does the request data matches the expected value?

[jeanali]

My form:

dd for the request( now I already had something called "جديد" in database in Arabic means new so when Add another "جديد" to database it's stored!

array:3 [▼ "_token" => "7W9TdN3AcyjxwgfatCqyvuse6rZ656R3fPkbrV0E" "category_name" => array:2 [▼ "ar" => "جديد" "en" => "new" ] "category_id" => "1" ]

Store method:

 ` public function store(Request $request)
   {
    $data = $request->validate([
        'category_name.*' => ['required','unique_translation:categories'],
        'category_id' => '',
    ],[],[
        'category_name.ar' => trans('site.category_nameـar'),
        'category_name.en' => trans('site.category_nameـen'),
    ]);

    Category::create([
        'category_name'=> $data['category_name'],
        'slug'=> Str::slug($data['category_name']['en']),
        'category_id'=>  $request->category_id
                        ? $data['category_id']
                        : NULL,
    ]);

    return redirect()->back()
        ->with('success',trans('site.message_added'));

}`

[ivanvermeyen]

After further investigation...

This:

Model::create([
    'slug' => ['ar' => '\u062c\u062f\u064a\u062f'],
    'name' => ['ar' => '\u062c\u062f\u064a\u062f'],
]);

is saved in the model with double slashes:

  #attributes: array:3 [
    "slug" => "{"ar":"\\u062c\\u062f\\u064a\\u062f"}"
    "name" => "{"ar":"\\u062c\\u062f\\u064a\\u062f"}"
    "id" => 1
  ]

But this:

Model::create([
    'slug' => ['ar' => 'جديد'],
    'name' => ['ar' => 'جديد'],
]);

is saved with single slashes:

 #attributes: array:3 [
    "slug" => "{"ar":"\u062c\u062f\u064a\u062f"}"
    "name" => "{"ar":"\u062c\u062f\u064a\u062f"}"
    "id" => 1
  ]

Now this test works:

/** @test */
public function it_handles_backslashes_in_values()
{
    Model::create([
        'slug' => ['ar' => '\u062c\u062f\u064a\u062f'],
        'name' => ['ar' => '\u062c\u062f\u064a\u062f'],
    ]);

    $rules = [
        'slug.*' => "{$this->rule}:{$this->table}",
        'name.*' => UniqueTranslationRule::for($this->table),
    ];

    $validation = Validator::make([
        'slug' => ['ar' => '\u062c\u062f\u064a\u062f'],
        'name' => ['ar' => '\u062c\u062f\u064a\u062f'],
    ], $rules);

    $this->assertTrue($validation->fails());
}

And also this one:

/** @test */
public function it_handles_backslashes_in_values2()
{
    Model::create([
        'slug' => ['ar' => 'جديد'],
        'name' => ['ar' => 'جديد'],
    ]);

    $rules = [
        'slug.*' => "{$this->rule}:{$this->table}",
        'name.*' => UniqueTranslationRule::for($this->table),
    ];

    $validation = Validator::make([
        'slug' => ['ar' => 'جديد'],
        'name' => ['ar' => 'جديد'],
    ], $rules);

    $this->assertTrue($validation->fails());
}

But not this one, because the model adds double slashes:

/** @test */
public function it_handles_backslashes_in_values3()
{
    Model::create([
        'slug' => ['ar' => '\u062c\u062f\u064a\u062f'],
        'name' => ['ar' => '\u062c\u062f\u064a\u062f'],
    ]);

    $rules = [
        'slug.*' => "{$this->rule}:{$this->table}",
        'name.*' => UniqueTranslationRule::for($this->table),
    ];

    $validation = Validator::make([
        'slug' => ['ar' => 'جديد'],
        'name' => ['ar' => 'جديد'],
    ], $rules);

    $this->assertTrue($validation->fails());
}

Since you don't have double slashes in the database, the 2nd test should apply to your use case, but at the moment I still don't know why it's not working on your end.
It could be a database collation problem, but I'm no expert on that.
Are your columns set to utf8_general_ci or something similar?

[jeanali]

Yep it's utf8_general_ci!

[ivanvermeyen]

Hi,

If I try to enter جديد as a value in a form of one of my projects this is what I end up seeing in the database:

If it is a JSON column:

If it is a TEXT column:

In both cases, validation was working as expected here.
I'm using MySQL 5.7 here.

Not sure if it matters but this is the charset it is using: