Prevent global config override #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that when setting a scoped option, there are
set*()
calls on the globalLocaleConfig
, which override the global config.So the following:
would give the second route the same config as the first route.
also, calls afterwards to
LocaleConfig::getSupportedLocales()
andLocaleConfig::getOmittedLocale()
would retain the value of the last route registration with a corresponding scoped config.It seems the two lines can simply be removed, but might be worth checking if they had another purpose?
added test that failed before the changes to LocalizedRoutesRegistrar