Skip to content

Rails 8.0 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.1', '3.2']
ruby-version: ['3.3', '3.4']
haml: [true, false]
steps:
- uses: actions/checkout@v4
Expand All @@ -34,7 +34,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.1
ruby-version: 3.3
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Run rubocop
run: bundle exec rubocop
Expand All @@ -47,7 +47,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.1
ruby-version: 3.3
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- uses: paambaati/codeclimate-action@v5.0.0
env:
Expand Down
113 changes: 1 addition & 112 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,112 +1 @@
require:
- rubocop-rails

AllCops:
DisplayCopNames: true
NewCops: enable
Exclude:
# - test/test_app/**/*
- rdoc/**/*
- vendor/**/*
# File generated by Rails
- '**/test_helper.rb'
- '**/spec_helper.rb'
- '**/rails_helper.rb'
- '**/schema.rb'
- '**/seeds.rb'
- '**/initializers/*.rb'
- '**/environments/*.rb'
- '**/config/puma.rb'
- '**/config/routes.rb'
- '**/config/spring.rb'
- '**/db/migrate/*.rb'
- '**/bin/*'
- '**/boot.rb'
- '**/config.ru'
- '**/environment.rb'
- '**/application.rb'
- '**/application_helper.rb'
- '**/application_controller.rb'
- '**/application_job.rb'
- '**/application_system_test_case.rb'
- '**/channels/**/*.rb'
- '**/rails'
- '**/bundle'
- '**/rake'
- '**/Rakefile'
- dry_crud.gemspec
- '**/Gemfile'
- '**/node_modules/**/*'

Metrics/ClassLength:
Max: 200
Exclude:
- '**/*_test.rb'

Metrics/ModuleLength:
Max: 150

Metrics/MethodLength:
Max: 18

Metrics/CyclomaticComplexity:
Max: 8

Metrics/AbcSize:
Max: 20
Exclude:
- '**/*_test.rb'

Metrics/BlockLength:
Exclude:
- '**/*_spec.rb'
- '**/*_test.rb'
- '**/*_examples.rb'

Layout/EmptyLinesAroundClassBody:
Enabled: false

Layout/EmptyLinesAroundModuleBody:
Enabled: false

Layout/EmptyLinesAroundBlockBody:
Exclude:
- '**/*_spec.rb'

Rails/ActionControllerTestCase:
Enabled: false

Rails/I18nLocaleTexts:
Exclude:
- '**/test/support/*.rb'

Rails/HelperInstanceVariable:
Enabled: false

Rails/LexicallyScopedActionFilter:
Enabled: false

Rails/OutputSafety:
Exclude:
- '**/*_test.rb'
- '**/*_spec.rb'

Style/ClassVars:
Exclude:
- '**/spec/**/*'

# Rails does not, we do not
Style/FrozenStringLiteralComment:
Enabled: false

Style/RegexpLiteral:
Enabled: false

Style/Attr:
Enabled: false

Style/IfUnlessModifier:
Enabled: false

Style/GuardClause:
Enabled: false
inherit_gem: { rubocop-rails-omakase: rubocop.yml }
45 changes: 23 additions & 22 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,46 +1,47 @@
source 'https://rubygems.org'
source "https://rubygems.org"

gem 'rails', '~> 7.1.0'
gem "rails", "~> 8.0.0"

gem 'puma'
gem "puma"

gem 'rake'
gem 'sdoc'
gem 'rspec-rails'
gem "rake"

gem 'haml'
gem 'jbuilder'
gem "rspec-rails"

gem 'kaminari'
gem "haml"
gem "jbuilder"

gem "sprockets-rails"
gem "kaminari"

gem "propshaft"
gem "jsbundling-rails"
gem "cssbundling-rails"
gem "turbo-rails"
gem "stimulus-rails"

gem 'bootsnap', require: false
gem "bootsnap", require: false

gem 'tzinfo-data', platforms: [:windows, :jruby]
gem "tzinfo-data", platforms: [ :windows, :jruby ]

group :development do
gem 'web-console'
gem 'rubocop'
gem 'rubocop-rails'
gem 'spring'
gem "web-console"
gem "rubocop"
gem "rubocop-rails-omakase"
gem "sdoc"
gem "spring"
end

gem 'simplecov', require: false
gem 'debug', platforms: [:mri, :windows]
gem "simplecov", require: false
gem "debug", platforms: [ :mri, :windows ], require: "debug/prelude"

# platform specific gems

platforms :ruby do
gem 'sqlite3'
gem "sqlite3"
end

platforms :jruby do
gem 'jdbc-sqlite3'
gem 'activerecord-jdbcsqlite3-adapter'
gem 'jruby-openssl'
gem "jdbc-sqlite3"
gem "activerecord-jdbcsqlite3-adapter"
gem "jruby-openssl"
end
Loading