Repository navigation
Conversation
Signed-off-by: Can <116688414+canblmz1@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft adds an opt-in, offline differential evaluation of the checkout's actual
AgentRuntimeusing native chunks and an optional PSJ preflight. It is a concrete development-dependency trial: I maintain prefix-safe-json and would like to learn whether retaining this comparison helps NoteGen's normal provider/runtime upgrade checks.Run with installed development dependencies on Node 22+:
The proposal adds one exact development dependency (
prefix-safe-json@0.6.1), a command, a test and scope documentation. The pnpm lock change is 11 added lines; its existing Ajv 8.20.0 dependency is reused. Application source, production dependencies and CI workflows are unchanged.The 24 cases use the unchanged runtime, context manager, permission engine, retry manager, queue and recorder. Healthy one/two-call controls verify exact inputs, original result IDs in the next request and the consumed final answer. Existing malformed-JSON, read-error and user-stop guards require zero callbacks. Other native cases emit diagnostic observations; a native refusal is accepted instead of requiring today's permissive behavior to persist.
The optional PSJ policy refuses closed JSON with
length/content_filter, missing finish evidence, late provider-error chunks, duplicate original IDs, schema-invalid input and a malformed sibling before any callback. Whole-batch/schema refusal is explicit. Authority is consumed once, matching original ID, exact name and exact input in the verified sequential fixture.Provider/application utilities, prompt, hooks, RAG, token count and store/service access are explicit stubs. Unreviewed module imports fail before evaluation; unexpected fetch/MCP/store/skill/image access throws. The only registered read tool appends input to memory. No Rust SSE decoder, Tauri host, raw HTTP bytes, real MCP/model/tool, note mutation, approval workflow, argument repair or desktop/mobile UI is tested. The finite preflight is an evaluation helper, not a production transport adapter or general concurrency/approval binding.
Validation on Windows / Node 22.23.2, using pnpm 9.15.9:
tsc --noEmit --incremental false, test-file ESLint, plugin protocol check and diff checks pass.The Linux / Node 24 fork verification also passes frozen installation, all 24 new cases, all 5 existing helper cases and the plugin protocol check. It asserts the exact reviewed source SHA before running:
7ff5fcd4f0eab698199e0194da8f5edd61a93037. Its manual workflow lives only in my fork and is not part of this PR.The earlier pinned-source standalone recipe records the current baseline separately. A native terminal/error check remains a valid fix; PSJ is optional. The useful feedback is whether this test dependency belongs in your development workflow or creates more maintenance than it saves. This is a source-level test proposal, not a claimed run of the latest desktop binary.