Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tests don't stop running in gh actions #227

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

kloV148
Copy link
Contributor

@kloV148 kloV148 commented Mar 16, 2024

closes #226

Sometimes vitest failed to eliminate worker. To solve this, the tests are now run in non-threaded mode.

More about this issue: vitest-dev/vitest#3077

Copy link

github-actions bot commented Mar 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 86.51% (🎯 80%)
⬇️ -6.72%
6854 / 7922
🟢 Statements 86.51% (🎯 80%)
⬇️ -6.72%
6854 / 7922
🔴 Functions 79.85% (🎯 80%)
⬇️ -5.86%
226 / 283
🟢 Branches 85.82% (🎯 80%)
⬇️ -4.92%
345 / 402
File CoverageNo changed files found.
Generated in workflow #623

Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we setup it at the vitest.config.ts?

@kloV148
Copy link
Contributor Author

kloV148 commented Mar 16, 2024

can we setup it at the vitest.config.ts?

We can use node:child_processs option in vitest.config.ts. But to do this, we need to migrate to vitest 1+

@TatianaFomina
Copy link
Contributor

Created issue to migrate to vitest 1+
#230

@neSpecc
Copy link
Member

neSpecc commented Mar 23, 2024

can we setup it at the vitest.config.ts?

We can use node:child_processs option in vitest.config.ts. But to do this, we need to migrate to vitest 1+

Are you sure? Each supported cli argument usually have corresponded config property. They are just different ways to pass a particular option

@kloV148 kloV148 merged commit 4ace00c into main Mar 25, 2024
6 checks passed
@kloV148 kloV148 mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent tests from running endlessly in Github actions
4 participants