Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate saved data #591

Merged
merged 39 commits into from
Jan 12, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
9ef5a79
Specify submodule branch for test
PolinaShneider Dec 21, 2018
dc734ec
Change branch for testing convenience
PolinaShneider Dec 28, 2018
fa69336
Added checklist submodule for test
PolinaShneider Jan 3, 2019
5f19cfe
Attempt to validate data on save
PolinaShneider Jan 9, 2019
fc3ef98
Rewrite promise.then to async/await
PolinaShneider Jan 9, 2019
dd788f9
Move validate logic to saver
PolinaShneider Jan 10, 2019
12d504b
Remove extra space
PolinaShneider Jan 10, 2019
bf4a57a
Fix tabs
PolinaShneider Jan 10, 2019
568e823
Don't need async/await here
PolinaShneider Jan 10, 2019
c5effb2
Remove submodule
PolinaShneider Jan 10, 2019
ca9216f
Improve logging, remove empty blocks from data array
PolinaShneider Jan 10, 2019
739de39
Remove warning
PolinaShneider Jan 10, 2019
5d52cec
Loop over blocks only once
PolinaShneider Jan 10, 2019
11a85ba
Make validate non-async
PolinaShneider Jan 10, 2019
07c80e5
Get rid of await Promise.all
PolinaShneider Jan 10, 2019
c4e41a9
Make validate async
PolinaShneider Jan 10, 2019
4f37f52
Call plugin's validate method with await
PolinaShneider Jan 10, 2019
ef1b52f
Add docs
PolinaShneider Jan 11, 2019
415d68b
Update docs
PolinaShneider Jan 11, 2019
bd3dbb8
Make separate function for tools validation
PolinaShneider Jan 11, 2019
769575a
Rename method
PolinaShneider Jan 11, 2019
787b07b
Add data types interfaces
PolinaShneider Jan 11, 2019
44ea5d7
Improve logging
PolinaShneider Jan 11, 2019
1969d7b
Desctructure extraction object
PolinaShneider Jan 12, 2019
9796c0a
Remove useless argument
PolinaShneider Jan 12, 2019
9355fed
Update README and changelog
PolinaShneider Jan 12, 2019
8eaa629
Make separate changelog for version
PolinaShneider Jan 12, 2019
fbdb88b
Increase version
PolinaShneider Jan 12, 2019
da742e1
Bump version
PolinaShneider Jan 12, 2019
68f7ebc
Merge branch 'master' of https://github.com/codex-team/codex.editor i…
gohabereg Jan 12, 2019
f4689e8
Keep logs at their places
PolinaShneider Jan 12, 2019
ec0a3da
Fix logs order
PolinaShneider Jan 12, 2019
373567d
Merge branch 'master' of https://github.com/codex-team/codex.editor i…
PolinaShneider Jan 12, 2019
83f4766
Pull submodules
PolinaShneider Jan 12, 2019
08c8251
Improve logs grouping
PolinaShneider Jan 12, 2019
fe87487
Merge branch 'master' of https://github.com/codex-team/codex.editor i…
PolinaShneider Jan 12, 2019
6e33bdf
log styles improved
neSpecc Jan 12, 2019
79aa7c1
Describe allExtractedData type
PolinaShneider Jan 12, 2019
38b066a
Improve JSDoc
PolinaShneider Jan 12, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' of https://github.com/codex-team/codex.editor i…
…nto validate-saved-data
  • Loading branch information
PolinaShneider committed Jan 12, 2019
commit fe87487b7ab1eb63dd828da4c8b5b735b59752c2
10 changes: 5 additions & 5 deletions dist/codex-editor.js

Large diffs are not rendered by default.

9 changes: 7 additions & 2 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
# Changelog

### 2.7.27 changelog
### 2.7.28

- `New` [Tools Validation](https://github.com/codex-team/codex.editor/blob/master/docs/tools.md#validate-optional) is added.

### 2.2.26 changelog
### 2.2.27

- `New` *Mobile view* — Editor now adopted for mobile devices
- `New` *Narrow mode* — Editor now adopted for narrow containers

### 2.2.26

- `Improvements` *Caret* — Improvements of the caret behaviour: arrows, backspace and enter keys better handling.

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "codex.editor",
"version": "2.7.27",
"version": "2.7.28",
"description": "CodeX Editor. Native JS, based on API and Open Source",
"main": "dist/codex-editor.js",
"types": "./types/index.d.ts",
Expand Down
2 changes: 0 additions & 2 deletions src/components/modules/saver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ export default class Saver extends Module {
});

const extractedData = await Promise.all(chainData);
neSpecc marked this conversation as resolved.
Show resolved Hide resolved

const sanitizedData = await Sanitizer.sanitizeBlocks(extractedData);

ModificationsObserver.enable();
Expand Down Expand Up @@ -72,7 +71,6 @@ export default class Saver extends Module {
console.groupCollapsed('[CodexEditor saving]:');

allExtractedData.forEach(({tool, data, time, isValid}) => {

totalTime += time;

if (isValid) {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.