Skip to content

resolve "Can't find a Block to remove" error in renderFromHTML #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neSpecc merged 2 commits into from
Sep 6, 2025
+7 −4
Merged

resolve "Can't find a Block to remove" error in renderFromHTML #2941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23f411b
fix(blocks):Error occurred when calling renderFromHTML: Can't find a …
narpat-ps Jun 15, 2025
69ad9f3
fix: resolve "Can't find a Block to remove" error in renderFromHTML
narpat-ps Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/modules/api/blocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@ export default class BlocksAPI extends Module {
* @param {string} data - HTML string to render
* @returns {Promise<void>}
*/
public renderFromHTML(data: string): Promise<void> {
this.Editor.BlockManager.clear();
public async renderFromHTML(data: string): Promise<void> {
await this.Editor.BlockManager.clear();

return this.Editor.Paste.processText(data, true);
}
Expand Down
7 changes: 5 additions & 2 deletions src/components/modules/blockManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,8 +533,8 @@ export default class BlockManager extends Module {
throw new Error('Can\'t find a Block to remove');
}

block.destroy();
this._blocks.remove(index);
block.destroy();

/**
* Force call of didMutated event on Block removal
Expand Down Expand Up @@ -894,7 +894,10 @@ export default class BlockManager extends Module {
public async clear(needToAddDefaultBlock = false): Promise<void> {
const queue = new PromiseQueue();

this.blocks.forEach((block) => {
// Create a copy of the blocks array to avoid issues with array modification during iteration
const blocksToRemove = [...this.blocks];

blocksToRemove.forEach((block) => {
queue.add(async () => {
await this.removeBlock(block, false);
});
Expand Down
Loading