Chore/popover refactoring #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TatianaFomina
commented
Jan 23, 2023
•
TatianaFomina
commented
- Popover class splitted into two separated classes: one for popover item and another for popover itself.
- Popover class contains general popover logic, such as handling keyboard navigation, opening overlay on mobile, adding search and so on.
- PopoverItem class includes item specific logic, such as managing confirmation states.
TatianaFomina
requested review from
neSpecc,
gohabereg and
ilyamore88
as code owners
neSpecc
reviewed
Jan 25, 2023
ilyamore88
reviewed
Jan 26, 2023
Co-authored-by: Ilya Maroz <37909603+ilyamore88@users.noreply.github.com>
neSpecc
approved these changes
Feb 10, 2023
gohabereg
approved these changes
Feb 10, 2023
ilyamore88
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.