Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(readonly): fix readonly property #1969

Merged
merged 3 commits into from
Feb 9, 2022
Merged

fix(readonly): fix readonly property #1969

merged 3 commits into from
Feb 9, 2022

Conversation

neSpecc
Copy link
Member

@neSpecc neSpecc commented Feb 9, 2022

  1. Added the statements checking if toolboxInstance is created
  2. Removed redundant event.preventDefault() from the passive scroll handler in the RectangleSelection
  3. Added test for the readOnly initialisation

Resolves #1968

@neSpecc neSpecc merged commit 640b1a2 into next Feb 9, 2022
@neSpecc neSpecc deleted the fix/1968 branch February 9, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gohabereg gohabereg gohabereg approved these changes

@khaydarov khaydarov Awaiting requested review from khaydarov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] v2.23.1 readOnly: true crashes the editor
2 participants
@neSpecc @gohabereg