refactoring(modules): sanitizer module is util now #1574
Conversation
src/components/utils/sanitizer.ts
Outdated
| return block; | ||
| } | ||
|
|
||
| block.data = this.deepSanitize(block.data, toolConfig) as BlockToolData; |
There was a problem hiding this comment.
this.deepSanitize -> deepSanitize ?
docs/CHANGELOG.md
Outdated
| @@ -25,9 +25,11 @@ | |||
| - `Refactoring` - The Listeners module now is a util. | |||
| - `Refactoring` - The Events module now is a util. | |||
| - `Fix` - Editor Config now immutable [#1552](https://github.com/codex-team/editor.js/issues/1552). | |||
| - `Refactoring` - The Sanitizer module is util now. | |||
src/components/utils/sanitizer.ts
Outdated
| * | ||
| * @example | ||
| * | ||
| * Sanitizer.clean(yourTaintString, yourConfig); |
src/components/utils/sanitizer.ts
Outdated
| */ | ||
| export function sanitizeBlocks( | ||
| blocksData: Array<Pick<SavedData, 'data' | 'tool'>>, | ||
| sanitizeConfig: (toolName: string) => SanitizerConfig | SanitizerConfig |
There was a problem hiding this comment.
why the sanitizeconfig is a function? maybe the config should be passed calculated?
There was a problem hiding this comment.
Each block has own sanitize config. We can pass a map name => config but I think function is better. However you can still pass an object which will be applied for all blocks
| @@ -42,7 +43,9 @@ export default class Saver extends Module { | |||
| }); | |||
There was a problem hiding this comment.
can we just call deepSanitize here and remove the sanitizeBlocks method?
There was a problem hiding this comment.
Each block has own sanitize config, so we can't
| @@ -249,7 +249,7 @@ export default abstract class BaseTool<Type extends Tool = Tool> { | |||
| * Returns Tool's sanitizer configuration | |||
| */ | |||
| public get sanitizeConfig(): SanitizerConfig { | |||
| return this.constructable[CommonInternalSettings.SanitizeConfig]; | |||
| return this.constructable[CommonInternalSettings.SanitizeConfig] || {}; | |||
There was a problem hiding this comment.
For Block Tools it will be still {} even if we return undefined here, for inline tools it helps us to get rid of unnecessary checks
| name: 'inlineTool', | ||
| constructable: class { | ||
| public static sanitize = { | ||
| b: true, |
There was a problem hiding this comment.
| b: true, | |
| a: true, |
No description provided.