Prepare plugins #148
Merged
Prepare plugins #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # codex-editor.js # codex-editor.js.map # whatwg-fetch.js.map
neSpecc
requested changes
Feb 3, 2017
codex.js
Outdated
| inputs : [] | ||
| jsonOutput : [], | ||
| blocks : [], | ||
| ArrayOfCachedData : [], |
There was a problem hiding this comment.
почему первое слово с большой буквы?
modules/draw.js
Outdated
| @@ -311,6 +311,16 @@ module.exports = (function (draw) { | |||
|
|
|||
| }; | |||
|
|
|||
| draw.unavailableBlock = function ( data ) { | |||
There was a problem hiding this comment.
в комментах нужно описать что за data. А лучше вынести ее из этой функции, тк dataset относится к логике, а тут только рисование
modules/renderer.js
Outdated
| var block = editor.tools[pluginName].render(blockData.data); | ||
| if ( editor.tools[pluginName].available === false ) { | ||
|
|
||
| block = editor.draw.unavailableBlock(ArrayOfCachedData.length); |
There was a problem hiding this comment.
ArrayOfCachedData.length — это что означает?
There was a problem hiding this comment.
уверен, что надежно так обращаться?
neSpecc
requested changes
Feb 3, 2017
modules/renderer.js
Outdated
| var block = editor.tools[pluginName].render(blockData.data); | ||
| if ( editor.tools[pluginName].available === false ) { | ||
|
|
||
| block = editor.draw.unavailableBlock(ArrayOfCachedData.length); |
There was a problem hiding this comment.
уверен, что надежно так обращаться?
neSpecc
approved these changes
Feb 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins preparation should be executed asynchronically