Fix SerializeReference on non serializable collections (#167)

codewriter-packages · Jul 18, 2024 · f2a652a · f2a652a
1 parent 6c844f0
commit f2a652a
Showing 1 changed file with 21 additions and 1 deletion.
diff --git a/Editor/Utilities/TriUnitySerializationUtilities.cs b/Editor/Utilities/TriUnitySerializationUtilities.cs
@@ -27,7 +27,27 @@ public static bool IsSerializableByUnity(FieldInfo fieldInfo)
 
             if (fieldInfo.GetCustomAttribute<SerializeReference>() != null)
             {
-                return true;
+                // if it's a list or array, the base type should be serializable
+                if (fieldInfo.FieldType.IsArray)
+                {
+                    var type = fieldInfo.FieldType.GetElementType();
+                    if (type.IsSerializable || type.IsInterface)
+                        return true;
+                    else
+                        return false;
+                }
+                else if (fieldInfo.FieldType.IsGenericType && fieldInfo.FieldType.GetGenericTypeDefinition() == typeof(List<>))
+                {
+                    var type = fieldInfo.FieldType.GenericTypeArguments[0];
+                    if (type.IsSerializable || type.IsInterface)
+                        return true;
+                    else
+                        return false;
+                }
+                else
+                {
+                    return true;
+                }
             }
 
             if (fieldInfo.IsPublic || fieldInfo.GetCustomAttribute<SerializeField>() != null)