-
Notifications
You must be signed in to change notification settings - Fork 2
Updates for base test and debugging capture #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Furthermore, it is not necessary to install testbox separately now as it is included as a dependency of this package.
should grab everything |
@bdw429s Thanks! I'm testing it and it seems to work when the test case passes, but no logs are shown when it fails :/ Also,
|
Oops, was typing from memory. I meant |
Good catch. It seems that the savecontent construct doesn't capture the nested output if there's an exception raised (failures raise an exception that the test framework catches). I'm not sure if that's right or not 🤔 No matter, I've worked around it in my latest commit so output makes it ot the debug stream even in the event of a failure. |
And in case anyone is keeping track... Re: cfdump format=text stupidly showing HTML Re; cfsavecontent losing content buffer prior to exception Those tickets don't affect this pull at all, I just linked to them since they came up in the conversation here. |
Thanks @bdw429s, I confirmed it working with failed cases as well. I'll let you know when I deploy it. I'll also update the template to use this base spec and increase the maximum allowed time to 16s. |
@kazk Sweet! What about the existing katas that need changed to use the new base test case? After this deploys should I go and suggest an edit to each kata? |
I can update the existing kata when this is deployed. It's currently only 15 so it shouldn't take long. If I don't have the time to, I'll ask you to suggest and edit. |
I just deployed to production and updated existing 15 CFML challenges. |
@kazk I just started a brand new CFML translation for |
Hmm, I just tried new translation and it showed |
Yep, that was it. I've probably had this Codewars browser window open for several days 😄 |
This change captures debug stream data from TestBox and logs it with the corresponding data. Also all test cases that extend
CodewarsBaseSpec
will automatically any output from the solution created viaand convert it to text for the log.
I recommend we edit existing CFML katas to extend this base test case instead of
testbox.system.baseSpec
and also modify the template test case to show this by default as well.