Fix pre-selected item when using belongs_to #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great lib!
We use it a lot in our application and found a small issue when using belongs_to in active admin.
-> To make
belongs_toworks with the lib, we have to addpath_paramsin theajaxoptions (as described here). But this example doesn't work when the Model already have a value (it is not preselected). It works well for subsequent search.-> This is because https://github.com/codevise/activeadmin-searchable_select/blob/master/lib/activeadmin/searchable_select/select_input_extension.rb#L87 is taking into account only the
paramsand not thepath_paramsduring initial load.In our code, to fix it we had to add it twice, which we guess is not intended:
cc @ChrLec