Skip to content

Wikis Feature #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Wikis Feature #581

merged 1 commit into from
Aug 30, 2020

Conversation

ksraj123
Copy link
Contributor

No description provided.

@ksraj123 ksraj123 changed the title Wikis Feature [WIP] Wikis Feature Aug 22, 2020
Copy link
Member

@Rupeshiya Rupeshiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @ksraj123 Please go through the comments once. Otherwise, your code looks pretty good.

@ksraj123
Copy link
Contributor Author

ksraj123 commented Aug 28, 2020

@Rupeshiya Suggested Changes made, please review again. Thanks. 👍

Copy link
Member

@Rupeshiya Rupeshiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!!
@ksraj123 Just squash your commits.
@AuraOfDivinity @ayushnagar123 Please review once

@AuraOfDivinity
Copy link
Collaborator

@ksraj123 @Rupeshiya I had look at all the files. Couldn't find any noticeable issues. As of now, it looks good for me! I will have a look again tomorrow. Great work @ksraj123 !

@ksraj123 ksraj123 force-pushed the feature-wikis branch 2 times, most recently from 755f0ad to 25211ab Compare August 30, 2020 13:37
@ksraj123
Copy link
Contributor Author

@Rupeshiya Commits squashed
@AuraOfDivinity @Rupeshiya Is this good to go?

@vaibhavdaren vaibhavdaren changed the title [WIP] Wikis Feature Wikis Feature Aug 30, 2020
@vaibhavdaren vaibhavdaren merged commit 77d0286 into codeuino:development Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants