Post Reactions #556
Merged
Post Reactions #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaskiratsingh2000 A few questions regarding this on my end,
|
|
Thanks for taking this up. Well, I think we could do in a same way as it is
showed inside the facebook
…On Mon, 3 Aug 2020, 3:58 pm Asel Peiris, ***@***.***> wrote:
@jaskiratsingh2000 <https://github.com/jaskiratsingh2000> A few questions
regarding this on my end,
1.
I think we should separate the user reactions to a particular post
from other functionalities such as "Adding to favorite" and bookmarking a
post. We could have these functionalities on the top right dropdown for
instance.
2.
How will we displaying the reactions to a particular post? Maybe we
could have a separate modal to display just like on Facebook? Something
like the following image?
[image: image]
<https://user-images.githubusercontent.com/31003923/89173597-24f9f280-d5a2-11ea-8e8f-76806f0cd10f.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#556 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOBHK5HYJCLV7WRCKLHR7LR62GOHANCNFSM4PTGFYKQ>
.
|
Rupeshiya
requested changes
Aug 3, 2020
|
Also @AuraOfDivinity Please add Pin icon, already told earlier as well. |
Rupeshiya
reviewed
Aug 5, 2020
| if(res.status === 200) { | ||
| dispatch(setRequestStatus(true)) | ||
| console.log('all posts ', res.data.posts) | ||
| const res = await axios.get( |
There was a problem hiding this comment.
@AuraOfDivinity Please remove these unnecessary format changes, this is a pretty annoying issue. Its destroying uniformity in the code style
| if(res.status === 200){ | ||
| dispatch(setRequestStatus(true)) | ||
| console.log('fetching all pinned posts ', res.data.pinnedPost) | ||
| const res = await axios.get( |
|
Updated reactions.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542
This is only the frontend implementation. Some changes to the backend might be required for other reactions (Heart, Happy and Donut) since only upvotes are supported at the moment