Skip to content

Implements markdown and priview functionality #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2020

Conversation

AuraOfDivinity
Copy link
Collaborator

Fixes #507

Implements Markdown and preview functionality.
fixmarkdownpost

Please review @Rupeshiya @jaskiratsingh2000 @vaibhavdaren @devesh-verma

@netlify
Copy link

netlify bot commented Jul 10, 2020

Deploy preview for donut-frontend failed.

Built with commit 48659f0

https://app.netlify.com/sites/donut-frontend/deploys/5f0836f3588ca70007081be2

Copy link
Member

@Rupeshiya Rupeshiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AuraOfDivinity But I think this is saving the HTML of the post content in the backend.
Also during rendering the post content in cards it's showing HTML.
Please handle this.
Thanks for this PR Asel. Great wotk 👍

Comment on lines +76 to +84
textpattern_patterns: [
{ start: "#", format: "h1" },
{ start: "##", format: "h2" },
{ start: "###", format: "h3" },
{ start: "####", format: "h4" },
{ start: "#####", format: "h5" },
{ start: "######", format: "h6" },
{ start: "* ", cmd: "InsertUnorderedList" },
{ start: "- ", cmd: "InsertUnorderedList" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am so happy to see this 👍

@jaskiratsingh2000
Copy link
Member

Glad to see this. Leaving on @vaibhavdaren to check within technicalties

@Rupeshiya
Copy link
Member

@AuraOfDivinity But I think this is saving the HTML of the post content in the backend.
Also during rendering the post content in cards it's showing HTML.
Please handle this.
Thanks for this PR Asel. Great wotk 👍

@AuraOfDivinity Is this issue fixed?

@vaibhavdaren
Copy link
Member

@AuraOfDivinity please fix asap

@AuraOfDivinity
Copy link
Collaborator Author

The content is rendered in the exact way it is typed in the editor now. @vaibhavdaren @Rupeshiya

image

@Rupeshiya
Copy link
Member

The content is rendered in the exact way it is typed in the editor now. @vaibhavdaren @Rupeshiya

image

Cool!!
Looks fine now.

@vaibhavdaren vaibhavdaren merged commit ace827a into codeuino:development Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants