Comment notifications #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for donut-frontend-r failed. Built with commit 3f91574 https://app.netlify.com/sites/donut-frontend-r/deploys/5f01c2a6ab32fd0007482cca |
Rupeshiya
requested changes
Jul 5, 2020
There was a problem hiding this comment.
@AuraOfDivinity Check the comments!
Everything else looks fine to me.
| this.state.socket.on("new proposal created", (data) => { | ||
| data.newNotification = true; | ||
| data.createdAt = new Date().toString().substring(0, 24); | ||
| this.setState({ |
There was a problem hiding this comment.
@AuraOfDivinity Instead of repeating this every time, just make a function and pass the value to set notifications
| className="user-image" | ||
| /> | ||
| </div> | ||
| <div className="idea-container"> |
There was a problem hiding this comment.
you are not using the tag for notifications??
jaskiratsingh2000
added
enhancement
This was referenced Jul 20, 2020
vaibhavdaren
added a commit
that referenced
this pull request
Aug 6, 2020
* Implements markdown and priview functionality * Parsing content within comment * Comment notifications (#501) * Initial * Addition of comments section * requested changes * Changes for Jitsi UI (#518) * css changes for jitsi box ui change * edited jitsi.scss for jitsi ui and reverted changes of comment.scss * changes made for making same fonts * added modals in jitsi ui * removed unnecessary code from jitsi.scss * fixing dev branch issues (#525) * implemented user activity and fix inconsistencies (#527) * Settings integrate and deploy configuration (#530) * integrated settings page and user activity modification * configure to deploy * Insights (#529) * Adding reactGA * Insights section * removing /hompage path * Requested changes * initial changes * Fetching data from the backend and integrating redux * Fixing modal issues (#531) * social links fix (#545) * fix issues (#555) * Fixing proposal functionality issues (#553) Co-authored-by: Asel <peirisasel373@gmail.com> Co-authored-by: Nisarg Shah <nisshah1499@gmail.com> Co-authored-by: Rupesh Krishna Jha <rupeshiya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Implements a separate section for comment notifications in the proposal dashboard page as discussed in the previous meeting. If some other user comments on one of your proposals a new notification is displayed accordingly at this section.
Please review @Rupeshiya @vaibhavdaren @devesh-verma