Cleanup Code #10
Merged
Cleanup Code #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazycipher
reviewed
Oct 5, 2020
| @@ -1,4 +1,3 @@ | |||
| MONGO_USER = "codeuino-user" | |||
| MONGO_PASSWORD = "thisisthewrongpassword" | |||
| DATABASE_URL="mongodb://<username>:<password>@cluster0-shard-00-00.t4hho.mongodb.net:27017,cluster0-shard-00-01.t4hho.mongodb.net:27017,cluster0-shard-00-02.t4hho.mongodb.net:27017/<dbname>?ssl=true&replicaSet=atlas-a80apd-shard-0&authSource=admin&retryWrites=true&w=majority" | |||
There was a problem hiding this comment.
You might want to remove this URL as it will be different for every mongo cluster.
Member
Author
There was a problem hiding this comment.
Yeah! Basically it was just a placeholder to make it clear on what type of URL is expected
Member
Author
|
@vaibhavdaren @capedcrusader23 @AuraOfDivinity please review and merge if all good |
| MONGO_PASSWORD = "thisisthewrongpassword" | ||
| DATABASE_URL="mongodb://<username>:<password>@cluster0-shard-00-00.t4hho.mongodb.net:27017,cluster0-shard-00-01.t4hho.mongodb.net:27017,cluster0-shard-00-02.t4hho.mongodb.net:27017/<dbname>?ssl=true&replicaSet=atlas-a80apd-shard-0&authSource=admin&retryWrites=true&w=majority" | ||
| JWT_SECRET = "somesupersecretkey" | ||
| PORT=8000 |
Member
There was a problem hiding this comment.
Suggested change
| PORT=8000 | |
| PORT=8000 | |
| var bind = typeof port === 'string' | ||
| ? 'Pipe ' + port | ||
| : 'Port ' + port; | ||
| var bind = typeof port === "string" ? "Pipe " + port : "Port " + port; |
| module.exports = { | ||
| messages: async (args, req) => { | ||
| if (!req.isAuth) { | ||
| throw new Error("Please login to continue"); |
vaibhavdaren
approved these changes
Oct 10, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Included in this PR:
Working after this: