Device returning JSON error

[xoniq]

This bug was already mentioned in the TuyApi/Cli repo, but it fits here better, since it seems to fail already within TuyApi itself, not just in cli.

How I run into this
Testing TuyApi with the sample code, I let the library find the device using the UDP broadcast, and it finds it, and determines it's version 3.3 (at least thats what TuyApi returns together with it's IP address).

Issue at TuyApi/Cli:
TuyaAPI/cli#23 (comment)

My latest findings in the linked issue (copy from the other issue, to keep it clean):

@codetheweb
(2 edits and more testing at the end of this feedback)

This is the response of a custom script against TuyAPI:

  TuyAPI Finding missing IP undefined or ID XXXXXXXXXXXXXXXXX +0ms
  TuyAPI Received UDP message. +77ms
  TuyAPI UDP data: +3ms
  TuyAPI { payload:
  TuyAPI    { ip: '192.168.1.XXX',
  TuyAPI      gwId: 'XXXXXXXXXXXXXXXXX',
  TuyAPI      active: 2,
  TuyAPI      ablilty: 0,
  TuyAPI      encrypt: true,
  TuyAPI      productKey: 'XXXXXXXXXXXXXXXXX',
  TuyAPI      version: '3.3' },
  TuyAPI   leftover: false,
  TuyAPI   commandByte: 19,
  TuyAPI   sequenceN: 0 } +0ms
  TuyAPI Connecting to 192.168.1.XXX... +4ms
  TuyAPI Socket connected. +73ms
Connected to device!
  TuyAPI GET Payload: +1ms
  TuyAPI { gwId: 'XXXXXXXXXXXXXXXXX',
  TuyAPI   devId: 'XXXXXXXXXXXXXXXXX' } +0ms
  TuyAPI Received data: 000055aa000000010000000a0000002c00000001e43a9f9fb09424634104f66db124feee8e3bf2aeee7be51f9590b6b57c1fe62e4f61356e0000aa55 +86ms
  TuyAPI Parsed: +0ms
  TuyAPI { payload: 'json obj data unvalid',
  TuyAPI   leftover: false,
  TuyAPI   commandByte: 10,
  TuyAPI   sequenceN: 1 } +0ms
Data from device: json obj data unvalid

Using this almost unchanged sample code:

const TuyAPI = require('tuyapi');

const device = new TuyAPI({
  id: 'XXXXXXXXXXXXXXXXX',
  key: 'XXXXXXXXXXXXXXXXX'});

let stateHasChanged = false;

// Find device on network
device.find().then(() => {
  // Connect to device
  device.connect();
});

// Add event listeners
device.on('connected', () => {
  console.log('Connected to device!');
});

device.on('disconnected', () => {
  console.log('Disconnected from device.');
});

device.on('error', error => {
  console.log('Error!', error);
});

device.on('data', data => {
  console.log('Data from device:', data);

  console.log(`Boolean status of default property: ${data.dps['1']}.`);

  // Set default property to opposite
  if (!stateHasChanged) {
    device.set({set: !(data.dps['1'])});

    // Otherwise we'll be stuck in an endless
    // loop of toggling the state.
    stateHasChanged = true;
  }
});

// Disconnect after 10 seconds
setTimeout(() => { device.disconnect(); }, 10000);

Command:

DEBUG=* node index.js

// EDIT 1/2 //

In file node_modules/tuyapi/lib/message-parser.js I followed it to getPayload (line 173) and did some console.log's, in the first try statement I can log the buffer, then after that it does:

data = this.cipher.decrypt(data);

Followed by another console.log which gives me the following (partially cutted unrelated feedback):

  TuyAPI Received data: 000055aa000000010000000a0000002c00000001e43a9f9fb09424634104f66db124feee8e3bf2aeee7be51f9590b6b57c1fe62e4f61356e0000aa55 +13ms
========== BEFORE this.cipher.decrypt ==========
<Buffer e4 3a 9f 9f b0 94 24 63 41 04 f6 6d b1 24 fe ee 8e 3b f2 ae ee 7b e5 1f 95 90 b6 b5 7c 1f e6 2e>
========== AFTER this.cipher.decrypt ==========
json obj data unvalid

No idea how to move further, also no idea if the json obj data unvalid text is really the decrypted text, or an error from cipher (given the spelling error in unvalid).

// EDIT 2/2 //

Tested more in cipher, the weird error is already generated here:

node_modules/tuyapi/lib/cipher.js (line 75)

      const decipher = crypto.createDecipheriv('aes-128-ecb', this.key, '');
      result = decipher.update(data, format, 'utf8');
      result += decipher.final('utf8');

It's the literal content of result after this part.
Tested a bit more on the cipher stuff:

      const decipher = crypto.createDecipheriv('aes-128-ecb', this.key, '');
      result = decipher.update(data, format, 'utf8');
      console.log( 'RESULT 1' );
      console.log( result );
      result += decipher.final('utf8');
      console.log( 'RESULT 2' );
      console.log( result );

Results in:

RESULT 1
json obj data un
RESULT 2
json obj data unvalid

At this point it goes to crypto, and now i'm clueless what I could test more. Looks like the decryption works perfectly, since it fails when I change alghoritm, so the error is the decoded message. Do I guess the JSON payload is not correct or something, for my device:

const payload = {
      gwId: this.device.gwID,
      devId: this.device.id
    };

[xoniq]

I was reeding this issue:
#234

Here I see the same error with spelling issue:
#234 (comment)
Data from device: json obj data unvalid

So it might be the payload.

[kueblc]

Thank you for your report. We added support for protocol 3.3 in v5.1.0.

Indeed, "json obj data unvalid" is the response from the device itself. This is a known issue. Has it impacted your ability to control the device?

[xoniq]

Yes, I cannot get info from the device with the default sample code, it fails twice with that error. Perhaps I could do beta testing on that version with my device?

(Good to know the response is from the device itself, than the cipher with my localkey is correct)

[kueblc]

Have you tried adding --protocol-version 3.3 to your tuya-cli call?

[xoniq]

Same response:

Command I ran:

DEBUG=* tuya-cli get --ip=192.168.1.XXX --id XXXXXXXXXXXXXXXX --key XXXXXXXXXXXXXXXX --protocol-version 3.3

Full response (debug):

  TuyAPI IP and ID are already both resolved. +0ms
  TuyAPI Connecting to 192.168.1.XXX... +3ms
  TuyAPI Socket connected. +7ms
  TuyAPI GET Payload: +1ms
  TuyAPI { gwId: 'XXXXXXXXXXXXXXXXXX',
  TuyAPI   devId: 'XXXXXXXXXXXXXXXXXX' } +0ms
  TuyAPI Received data: 000055aa000000010000000a0000002c00000001be51b49eb0e0e5a69755bd7f960400b0aa75b369e6048966cb8c9c2eb3d09422e43fba380000aa55 +15ms
  TuyAPI Parsed: +2ms
  TuyAPI { payload: 'json obj data unvalid',
  TuyAPI   leftover: false,
  TuyAPI   commandByte: 10,
  TuyAPI   sequenceN: 1 } +0ms
  TuyAPI GET Payload: +6ms
  TuyAPI { gwId: 'XXXXXXXXXXXXXXXXXX',
  TuyAPI   devId: 'XXXXXXXXXXXXXXXXXX' } +2ms
  TuyAPI Received data: 000055aa000000020000000a0000002c00000001be51b49eb0e0e5a69755bd7f960400b0aa75b369e6048966cb8c9c2eb3d09422dbf4c4ad0000aa55 +24ms
  TuyAPI Parsed: +1ms
  TuyAPI { payload: 'json obj data unvalid',
  TuyAPI   leftover: false,
  TuyAPI   commandByte: 10,
  TuyAPI   sequenceN: 2 } +0ms
  TuyAPI Disconnect +0ms
TypeError: Cannot read property '1' of undefined
    at Object.get (/opt/local/lib/node_modules/@tuyapi/cli/lib/control.js:56:30)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  TuyAPI Socket closed: 192.168.1.XXX +2ms

I must say, it's from a new Dutch brand LSC Smart Connect, sold by the Dutch/German franchise 'Action'. Is the payload actually changed or something?

[xoniq]

Damn Github mobile, closed it by accident.

[codetheweb]

@kueblc do you think it's possible his device uses v3.2? Behavior seems consistent. #234

[xoniq]

I honestly don't know. When I use the TuyApi without any checks, and I run this code:

const device = new TuyAPI({
  id: 'XXXXXXXXXXXXXXXXX',
  key: 'XXXXXXXXXXXXXXXXX'});

// Find device on network
device.find().then(() => {
  // Connect to device
  device.connect();
});

It finds it automatically and also automatically assigns the 3.3 version to it. I don't know what the difference is.

Do you have some suggestions I could try?

[kueblc]

This seems related to #219, though I was unable to find any difference between @haimkastner's recording of the app and tuyapi.

@xoniq do you have control of the device via the mobile app? If you can capture the network traffic between the phone and device while your internet is down, we could try to determine if there are any changes to the protocol that we missed.

[xoniq]

I will try, then I should clean up a Raspberry Pi to try this with. My Mac gives a kernel panic after fiddling with this. Will update ASAP if I manage to collect offline data.

[xoniq]

It seems not possible for me to do this. I have a raspberry pi which I can install as AP but then I don't have an internet connection and I cannot do the device. My Mac with shared internet connection to do this, I get kernel panics. So there isn’t much for me to do this with an offline connection.