Incident Notes #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality to link visit to lab, and updated the schema to have a visitId in the Lab model. fix HospitalRun#2184
There was a problem hiding this comment.
Awesome PR! Most of my comments were focused on permissions issues but other than that, I think error + edge-case handling is pretty good. Test coverage seems sufficient, but just be aware that the core contributors might ask for useAddIncidentNote.tsx and useDeleteIncidentNote.tsx tests (both handling successes and failures).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes HospitalRun#2497.
We refactored some of the patient notes code to support adding, deleting, and editing notes for incidents.