Skip to content

Enable django 2 support#4

Open
desecho wants to merge 2 commits intocodesyntax:masterfrom
desecho:django2
Open

Enable django 2 support#4
desecho wants to merge 2 commits intocodesyntax:masterfrom
desecho:django2

Conversation

@desecho
Copy link

@desecho desecho commented Feb 11, 2018

It is still not working however because of https://github.com/KristianOellegaard/django-hvad

@erral erral self-requested a review February 12, 2018 07:32
Copy link
Member

@erral erral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Can you add also this to the .travis.yml file?

We don't have an extensive test coverage, but this way we can make travis run the tests also with Django 2. I think something like this will do it:

python:
  - "2.7"
  - "3.4"
  - "3.5"
  - "3.6"

env:
  - DJANGO="Django>=1.9.0,<1.10.0"
  - DJANGO="Django>=1.10.0,<1.11.0"
  - DJANGO="Django>=1.11.0,<2.0.0"
  - DJANGO="Django>=2.0,<2.1"

@desecho
Copy link
Author

desecho commented Apr 11, 2021

I made the changes. However, since https://github.com/KristianOellegaard/django-hvad still does not support Django 2 it still won't work. Somebody needs to update that project as well.

@erral erral requested a review from urtzai April 12, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants