Open
Conversation
erral
requested changes
Feb 12, 2018
Member
There was a problem hiding this comment.
Thanks for your contribution!
Can you add also this to the .travis.yml file?
We don't have an extensive test coverage, but this way we can make travis run the tests also with Django 2. I think something like this will do it:
python:
- "2.7"
- "3.4"
- "3.5"
- "3.6"
env:
- DJANGO="Django>=1.9.0,<1.10.0"
- DJANGO="Django>=1.10.0,<1.11.0"
- DJANGO="Django>=1.11.0,<2.0.0"
- DJANGO="Django>=2.0,<2.1"
Author
|
I made the changes. However, since https://github.com/KristianOellegaard/django-hvad still does not support Django 2 it still won't work. Somebody needs to update that project as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is still not working however because of https://github.com/KristianOellegaard/django-hvad